Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 14588006: Fix VirtualPath::GetNormalizedFilePath on Windows (Closed)

Created:
7 years, 7 months ago by kinuko
Modified:
7 years, 7 months ago
Reviewers:
calvinlo, Gaurav, tzik
CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch, darin-cc_chromium.org
Visibility:
Public.

Description

Fix VirtualPath::GetNormalizedFilePath on Windows The current code seems to generate '/\foo' for a given path '\foo' BUG=238212 TEST=FileSystemUtilTest.GetNormalizedFilePath TBR=grv@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198822

Patch Set 1 : #

Patch Set 2 : build fix #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M webkit/fileapi/file_system_util.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/file_system_util_unittest.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
kinuko
(This is not the only problem, I have one more patch) PTL
7 years, 7 months ago (2013-05-07 17:40:42 UTC) #1
kinuko
7 years, 7 months ago (2013-05-07 17:41:02 UTC) #2
Gaurav
On 2013/05/07 17:41:02, kinuko wrote: lgtm rubber-stamp
7 years, 7 months ago (2013-05-07 18:16:32 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 7 months ago (2013-05-07 18:35:40 UTC) #4
kinuko
TBR-ing tzik
7 years, 7 months ago (2013-05-07 18:45:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/14588006/23002
7 years, 7 months ago (2013-05-07 18:54:58 UTC) #6
kinuko
Committed patchset #3 manually as r198822 (presubmit successful).
7 years, 7 months ago (2013-05-07 23:07:06 UTC) #7
calvinlo
lgtm
7 years, 7 months ago (2013-05-08 02:47:43 UTC) #8
tzik
7 years, 7 months ago (2013-05-08 03:21:37 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698