ui/base/resource: Roll our own version of ReadBigEndian() function.

base/big_endian.h

Index: base/big_endian.h
diff --git a/net/base/big_endian.h b/base/big_endian.h
similarity index 91%
rename from net/base/big_endian.h
rename to base/big_endian.h
index 911f3c5074d5664943fd5a4c22008597f7c9dc7d..15fba2b808749049421bbc6a99a305d7e51f9d62 100644
--- a/net/base/big_endian.h
+++ b/base/big_endian.h
@@ -2,14 +2,14 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef NET_BASE_BIG_ENDIAN_H_
-#define NET_BASE_BIG_ENDIAN_H_
+#ifndef BASE_BIG_ENDIAN_H_
+#define BASE_BIG_ENDIAN_H_
 
+#include "base/base_export.h"
 #include "base/basictypes.h"
 #include "base/strings/string_piece.h"
-#include "net/base/net_export.h"
 
-namespace net {
+namespace base {
 
 // Read an integer (signed or unsigned) from |buf| in Big Endian order.
 // Note: this loop is unrolled with -O1 and above.
@@ -49,7 +49,7 @@ inline void WriteBigEndian<uint8>(char buf[], uint8 val) {
 
 // Allows reading integers in network order (big endian) while iterating over
 // an underlying buffer. All the reading functions advance the internal pointer.
-class NET_EXPORT BigEndianReader {
+class BASE_EXPORT BigEndianReader {
  public:
   BigEndianReader(const void* buf, size_t len);

[Mark Mentovai, 2014/02/18 17:14:30]

I would be more comfortable if buf were typed (const char*?). Same on line 80
(char*?). This might put a casting onus on callers—how many callers would need
to be changed if the interface changed to char*?

(Reading through some of the rest of this change, I see that some users of
BigEndianReader/Writer already cast to char*.)

[tfarina, 2014/02/23 03:45:01]

Done.

 
@@ -75,7 +75,7 @@ class NET_EXPORT BigEndianReader {
 
 // Allows writing integers in network order (big endian) while iterating over
 // an underlying buffer. All the writing functions advance the internal pointer.
-class NET_EXPORT BigEndianWriter {
+class BASE_EXPORT BigEndianWriter {
  public:
   BigEndianWriter(void* buf, size_t len);
 
@@ -97,7 +97,6 @@ class NET_EXPORT BigEndianWriter {
   char* end_;
 };
 
-}  // namespace net
-
-#endif  // NET_BASE_BIG_ENDIAN_H_
+}  // namespace base
 
+#endif  // BASE_BIG_ENDIAN_H_