Fix for 165634

chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/webstore_private/webstore_private_api.h"
 
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/lazy_instance.h"
 #include "base/memory/scoped_vector.h"
@@ skipping 551 matching lines @@
     // Show the app list to show download is progressing. Don't show the app
     // list on first app install so users can be trained to open it themselves.
     if (approval_->enable_launcher)
       app_list_service->CreateForProfile(GetProfile());
     else
       app_list_service->AutoShowForProfile(GetProfile());
   }
 
   // The extension will install through the normal extension install flow, but
   // the whitelist entry will bypass the normal permissions install dialog.
-  scoped_refptr<WebstoreInstaller> installer = new WebstoreInstaller(
-      GetProfile(),
-      this,
-      &(dispatcher()->delegate()->GetAssociatedWebContents()->GetController()),
-      params->expected_id,
-      approval_.Pass(),
-      WebstoreInstaller::INSTALL_SOURCE_OTHER);
+  scoped_refptr<WebstoreInstaller> installer =
+      new WebstoreInstaller(GetProfile(),
+                            this,
+                            GetAssociatedWebContents(),

[tmdiep, 2014/02/11 23:27:34]

Thanks for investigating this issue and submitting the patch! I submitted
essentially the same patch yesterday and it has just been lgtm'ed by an owner:
https://codereview.chromium.org/138803012

Before I commit, just wanted to check with you - where our patches differ is
here. Is calling GetAssociatedWebContents() essential to the fix? Or can
dispatcher()->delegate()->GetAssociatedWebContents() be used?

+                            params->expected_id,
+                            approval_.Pass(),
+                            WebstoreInstaller::INSTALL_SOURCE_OTHER);
   installer->Start();
 
   return true;
 }
 
 void WebstorePrivateCompleteInstallFunction::OnExtensionInstallSuccess(
     const std::string& id) {
   if (test_webstore_installer_delegate)
     test_webstore_installer_delegate->OnExtensionInstallSuccess(id);
 
@@ skipping 91 matching lines @@
   return true;
 }
 
 bool WebstorePrivateIsInIncognitoModeFunction::RunImpl() {
   results_ = IsInIncognitoMode::Results::Create(
       GetProfile() != GetProfile()->GetOriginalProfile());
   return true;
 }
 
 }  // namespace extensions