Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3978)

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

Issue 1458723002: Finish implementing ChromeVox Next active indicator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@load_key_map
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
index acc665d5faa6501bf0fa746c7b5047d31823d4f0..ee945044e9f43e0cf7b995511c7c3428ac106497 100644
--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
@@ -146,6 +146,8 @@ Background.prototype = {
if (!value)
return;
+ value.start.node.makeVisible();
Peter Lundblad 2015/11/20 11:15:03 I recommend setting the value first or ignoring ex
dmazzoni 2015/11/20 23:35:14 Done.
+
this.currentRange_ = value;
},
@@ -324,8 +326,8 @@ Background.prototype = {
.onSpeechEnd(function() { continueReading(prevRange); })
.go();
prevRange = this.currentRange_;
- this.currentRange_ =
- this.currentRange_.move(cursors.Unit.NODE, Dir.FORWARD);
+ this.currentRange =
+ this.currentRange.move(cursors.Unit.NODE, Dir.FORWARD);
if (!this.currentRange_ || this.currentRange_.equals(prevRange))
global.isReadingContinuously = false;
@@ -401,7 +403,7 @@ Background.prototype = {
actionNode.focus();
var prevRange = this.currentRange_;
- this.currentRange_ = current;
+ this.currentRange = current;
new Output().withSpeechAndBraille(
this.currentRange_, prevRange, Output.EventType.NAVIGATE)

Powered by Google App Engine
This is Rietveld 408576698