Finish implementing ChromeVox Next active indicator.

chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview The entry point for all ChromeVox2 related code for the
  * background page.
  */
 
 goog.provide('Background');
@@ skipping 128 matching lines @@
   },
 
   get currentRange() {
     return this.currentRange_;
   },
 
   set currentRange(value) {
     if (!value)
       return;
 
+    value.start.node.makeVisible();

[Peter Lundblad, 2015/11/20 11:15:03]

I recommend setting the value first or ignoring exceptions fro makeVisible.
Otherwise, chromevox could get stuck if makeVisible would for some
reason throw and makeVisible is not critical for the operation of chromevox.

[dmazzoni, 2015/11/20 23:35:14]

Done.

+
     this.currentRange_ = value;
   },
 
   /**
    * Handles ChromeVox Next commands.
    * @param {string} command
    * @param {boolean=} opt_bypassModeCheck Always tries to execute the command
    *    regardless of mode.
    * @return {boolean} True if the command should propagate.
    */
@@ skipping 158 matching lines @@
         global.isReadingContinuously = true;
         var continueReading = function(prevRange) {
           if (!global.isReadingContinuously || !this.currentRange_)
             return;
 
           new Output().withSpeechAndBraille(
                   this.currentRange_, prevRange, Output.EventType.NAVIGATE)
               .onSpeechEnd(function() { continueReading(prevRange); })
               .go();
           prevRange = this.currentRange_;
-          this.currentRange_ =
-              this.currentRange_.move(cursors.Unit.NODE, Dir.FORWARD);
+          this.currentRange =
+              this.currentRange.move(cursors.Unit.NODE, Dir.FORWARD);
 
           if (!this.currentRange_ || this.currentRange_.equals(prevRange))
             global.isReadingContinuously = false;
         }.bind(this);
 
         continueReading(null);
         return false;
       case 'showContextMenu':
         if (this.currentRange_) {
           var actionNode = this.currentRange_.start.node;
@@ skipping 55 matching lines @@
     }
 
     if (current) {
       // TODO(dtseng): Figure out what it means to focus a range.
       var actionNode = current.start.node;
       if (actionNode.role == RoleType.inlineTextBox)
         actionNode = actionNode.parent;
       actionNode.focus();
 
       var prevRange = this.currentRange_;
-      this.currentRange_ = current;
+      this.currentRange = current;
 
       new Output().withSpeechAndBraille(
               this.currentRange_, prevRange, Output.EventType.NAVIGATE)
           .go();
     }
 
     return false;
   },
 
   /**
@@ skipping 268 matching lines @@
     return glob.replace(/[.+^$(){}|[\]\\]/g, '\\$&')
         .replace(/\*/g, '.*')
         .replace(/\?/g, '.');
   }).join('|') + ')$');
 };
 
 /** @type {Background} */
 global.backgroundObj = new Background();
 
 });  // goog.scope