Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 1458713002: Compute out arguments size (Closed)

Created:
5 years, 1 month ago by sehr
Modified:
5 years, 1 month ago
Reviewers:
Jim Stichnoth, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Compute the size of the stack space required to send the parameters to a call. BUG= R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=4163b9fcd92c0e2604a0d5f52ad1eccc86cad266

Patch Set 1 #

Patch Set 2 : Add call instruction API. #

Patch Set 3 : Compute arg are size #

Patch Set 4 : Merged and rebased to Joao's change #

Patch Set 5 : Merge 32 and 64 bit argument size #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -5 lines) Patch
M src/IceTargetLoweringMIPS32.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/IceTargetLoweringX8632Traits.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/IceTargetLoweringX86Base.h View 1 2 3 4 1 chunk +1 line, -4 lines 0 comments Download
M src/IceTargetLoweringX86BaseImpl.h View 1 2 3 4 1 chunk +43 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (2 generated)
sehr
First version for x86. PTAL.
5 years, 1 month ago (2015-11-21 00:36:16 UTC) #3
John
lgtm
5 years, 1 month ago (2015-11-21 01:03:28 UTC) #4
sehr
Committed patchset #5 (id:80001) manually as 4163b9fcd92c0e2604a0d5f52ad1eccc86cad266 (presubmit successful).
5 years, 1 month ago (2015-11-21 05:09:35 UTC) #5
Jim Stichnoth
5 years, 1 month ago (2015-11-22 04:12:16 UTC) #6
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/1458713002/diff/80001/src/IceTargetLoweringX8...
File src/IceTargetLoweringX86BaseImpl.h (right):

https://codereview.chromium.org/1458713002/diff/80001/src/IceTargetLoweringX8...
src/IceTargetLoweringX86BaseImpl.h:5360: if
(isScalarFloatingType(Dest->getType())) {
use DestType instead of Dest->getType()

Powered by Google App Engine
This is Rietveld 408576698