third_party/WebKit/Source/platform/scroll/Scrollbar.cpp - Issue 1458703010: Mac: Don't repaint scrollbars every frame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/Scrollbar.cpp

Issue 1458703010: Mac: Don't repaint scrollbars every frame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master2

Patch Set: Rebase and resolve Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/scroll/Scrollbar.cpp

diff --git a/third_party/WebKit/Source/platform/scroll/Scrollbar.cpp b/third_party/WebKit/Source/platform/scroll/Scrollbar.cpp

index 19538b25345adfea775bd2084f30f5c464d38b67..469b6394d93039316d13b0c77627a23340e1f873 100644

--- a/third_party/WebKit/Source/platform/scroll/Scrollbar.cpp

+++ b/third_party/WebKit/Source/platform/scroll/Scrollbar.cpp

@@ -61,6 +61,8 @@ Scrollbar::Scrollbar(ScrollableArea* scrollableArea, ScrollbarOrientation orient

, m_overlapsResizer(false)

, m_isAlphaLocked(false)

, m_elasticOverscroll(0)

+ , m_trackNeedsRepaint(true)

+ , m_thumbNeedsRepaint(true)

{

if (!m_theme)

m_theme = ScrollbarTheme::theme();

@@ -541,6 +543,10 @@ float Scrollbar::scrollableAreaCurrentPos() const

void Scrollbar::setNeedsPaintInvalidation()

{

+ if (m_theme->shouldRepaintAllPartsOnInvalidation()) {

+ m_trackNeedsRepaint = true;

+ m_thumbNeedsRepaint = true;

+ }

if (m_scrollableArea)

m_scrollableArea->setScrollbarNeedsPaintInvalidation(this);

}