ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.h - Issue 1458703009: Remove ServiceIsNullForTesting override for FaviconServiceFactory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.h

Issue 1458703009: Remove ServiceIsNullForTesting override for FaviconServiceFactory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comment fix Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ios/chrome/browser/favicon/favicon_service_factory.cc ('K') | « ios/chrome/browser/favicon/favicon_service_factory.cc ('k') | ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.cc » ('j') | ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.h

diff --git a/ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.h b/ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.h

index d6611c3025ca4237163443bd00f8f51ce896d135..04ec2a9e5087d280916a99a07a9abd3c8c4e89eb 100644

--- a/ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.h

+++ b/ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.h

@@ -34,6 +34,11 @@ class IOSChromeLargeIconServiceFactory

static IOSChromeLargeIconServiceFactory* GetInstance();

+ // Returns the default factory used to build IOSChromeLargeIconService. Can be

+ // registered with SetTestingFactory to use the IOSChromeLargeIconService

+ // instance during testing.

+ static TestingFactoryFunction GetDefaultFactory();

private:

friend struct base::DefaultSingletonTraits<IOSChromeLargeIconServiceFactory>;