Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: ios/chrome/browser/favicon/favicon_service_factory.h

Issue 1458703009: Remove ServiceIsNullForTesting override for FaviconServiceFactory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment fix Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/favicon/favicon_service_factory.h
diff --git a/ios/chrome/browser/favicon/favicon_service_factory.h b/ios/chrome/browser/favicon/favicon_service_factory.h
index 53c339e442312134a8def9982744ff415b748596..1e43ce5818da244fbbdaa57ff01bfa411d9fbb9a 100644
--- a/ios/chrome/browser/favicon/favicon_service_factory.h
+++ b/ios/chrome/browser/favicon/favicon_service_factory.h
@@ -32,6 +32,10 @@ class FaviconServiceFactory : public BrowserStateKeyedServiceFactory {
ios::ChromeBrowserState* browser_state,
ServiceAccessType access_type);
static FaviconServiceFactory* GetInstance();
+ // Returns the default factory used to build IOSChromeLargeIconService. Can be
sdefresne 2015/11/21 01:52:03 nit: blank line before the comment (as you did in
+ // registered with SetTestingFactory to use the IOSChromeLargeIconService
+ // instance during testing.
+ static TestingFactoryFunction GetDefaultFactory();
private:
friend struct base::DefaultSingletonTraits<FaviconServiceFactory>;

Powered by Google App Engine
This is Rietveld 408576698