ios/chrome/browser/favicon/favicon_service_factory.h - Issue 1458703009: Remove ServiceIsNullForTesting override for FaviconServiceFactory

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/favicon/favicon_service_factory.h

Issue 1458703009: Remove ServiceIsNullForTesting override for FaviconServiceFactory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove return null for testing instead Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | ios/chrome/browser/favicon/favicon_service_factory.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef IOS_CHROME_BROWSER_FAVICON_FAVICON_SERVICE_FACTORY_H_	5 #ifndef IOS_CHROME_BROWSER_FAVICON_FAVICON_SERVICE_FACTORY_H_

6 #define IOS_CHROME_BROWSER_FAVICON_FAVICON_SERVICE_FACTORY_H_	6 #define IOS_CHROME_BROWSER_FAVICON_FAVICON_SERVICE_FACTORY_H_

7	7

8 #include "base/macros.h"	8 #include "base/macros.h"

9 #include "base/memory/scoped_ptr.h"	9 #include "base/memory/scoped_ptr.h"

10 #include "components/keyed_service/ios/browser_state_keyed_service_factory.h"	10 #include "components/keyed_service/ios/browser_state_keyed_service_factory.h"

(...skipping 24 matching lines...) Expand all Loading...
35	35

36 private:	36 private:

37 friend struct base::DefaultSingletonTraits<FaviconServiceFactory>;	37 friend struct base::DefaultSingletonTraits<FaviconServiceFactory>;

38	38

39 FaviconServiceFactory();	39 FaviconServiceFactory();

40 ~FaviconServiceFactory() override;	40 ~FaviconServiceFactory() override;

41	41

42 // BrowserStateKeyedServiceFactory implementation.	42 // BrowserStateKeyedServiceFactory implementation.

43 scoped_ptr<KeyedService> BuildServiceInstanceFor(	43 scoped_ptr<KeyedService> BuildServiceInstanceFor(

44 web::BrowserState* context) const override;	44 web::BrowserState* context) const override;

45 bool ServiceIsNULLWhileTesting() const override;

46	45

47 DISALLOW_COPY_AND_ASSIGN(FaviconServiceFactory);	46 DISALLOW_COPY_AND_ASSIGN(FaviconServiceFactory);

48 };	47 };

49	48

50 } // namespace ios	49 } // namespace ios

51	50

52 #endif // IOS_CHROME_BROWSER_FAVICON_FAVICON_SERVICE_FACTORY_H_	51 #endif // IOS_CHROME_BROWSER_FAVICON_FAVICON_SERVICE_FACTORY_H_

OLD	NEW