Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: pkg/compiler/lib/src/cps_ir/share_interceptors.dart

Issue 1458703007: dart2js cps: Refactor CallExpressions into Primitives. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Another minor fix Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/cps_ir/share_interceptors.dart
diff --git a/pkg/compiler/lib/src/cps_ir/share_interceptors.dart b/pkg/compiler/lib/src/cps_ir/share_interceptors.dart
index 1fbbba31f6bccaa13d320a52eca9eb96303c4e6c..6a9898771f09f9d33325604a14d1302cd273b248 100644
--- a/pkg/compiler/lib/src/cps_ir/share_interceptors.dart
+++ b/pkg/compiler/lib/src/cps_ir/share_interceptors.dart
@@ -142,8 +142,7 @@ class ShareInterceptors extends TrampolineRecursiveVisitor implements Pass {
type: interceptor.type,
sourceInformation: interceptor.sourceInformation);
constantPrim.useElementAsHint(interceptor.hint);
- constantPrim.substituteFor(interceptor);
- interceptor.destroy();
+ interceptor..replaceUsesWith(constantPrim)..destroy();
let.remove();
} else if (interceptor.isAlwaysNullOrIntercepted) {
Primitive input = interceptor.input.definition;
@@ -167,8 +166,7 @@ class ShareInterceptors extends TrampolineRecursiveVisitor implements Pass {
cps.invokeContinuation(cont, [constantPrim]);
cps.context = cont;
cps.insertAbove(let);
- param.substituteFor(interceptor);
- interceptor.destroy();
+ interceptor..replaceUsesWith(param)..destroy();
let.remove();
}
}
@@ -188,8 +186,7 @@ class ShareInterceptors extends TrampolineRecursiveVisitor implements Pass {
if (existing != null) {
existing.interceptedClasses.addAll(interceptor.interceptedClasses);
existing.flags |= interceptor.flags;
- existing.substituteFor(interceptor);
- interceptor.destroy();
+ interceptor..replaceUsesWith(existing)..destroy();
node.remove();
return next;
}
@@ -257,9 +254,8 @@ class ShareConstants extends TrampolineRecursiveVisitor {
Constant prim = node.primitive;
Constant existing = sharedConstantFor[prim.value];
if (existing != null) {
- existing.substituteFor(prim);
existing.useElementAsHint(prim.hint);
- prim.destroy();
+ prim..replaceUsesWith(existing)..destroy();
node.remove();
return next;
}

Powered by Google App Engine
This is Rietveld 408576698