pkg/compiler/lib/src/cps_ir/mutable_ssa.dart - Issue 1458703007: dart2js cps: Refactor CallExpressions into Primitives.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/cps_ir/mutable_ssa.dart

Issue 1458703007: dart2js cps: Refactor CallExpressions into Primitives. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Another minor fix Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/cps_ir/mutable_ssa.dart

diff --git a/pkg/compiler/lib/src/cps_ir/mutable_ssa.dart b/pkg/compiler/lib/src/cps_ir/mutable_ssa.dart

index d4630b5abceb40bc9715e04c9db12b2ed40edc51..e5ea7a82ce1a5c77040dfcffcc06898cb0a80413 100644

--- a/pkg/compiler/lib/src/cps_ir/mutable_ssa.dart

+++ b/pkg/compiler/lib/src/cps_ir/mutable_ssa.dart

@@ -168,7 +168,7 @@ class MutableVariableEliminator implements Pass {

if (shouldRewrite(variable)) {

// Replace with the reaching definition from the environment.

Primitive value = environment[variable];

- value.substituteFor(getter);

+ getter.replaceUsesWith(value);

mergeHints(variable, value);

node.remove();

}