pkg/compiler/lib/src/cps_ir/cps_ir_integrity.dart - Issue 1458703007: dart2js cps: Refactor CallExpressions into Primitives.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_integrity.dart

Issue 1458703007: dart2js cps: Refactor CallExpressions into Primitives. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/cps_ir/cps_ir_integrity.dart

diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_integrity.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_integrity.dart

index dedfbadc60474ac8c557021890280d11993abcae..a2959025b8358e2af077f2134e37a00c74a6c348 100644

--- a/pkg/compiler/lib/src/cps_ir/cps_ir_integrity.dart

+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_integrity.dart

@@ -154,6 +154,9 @@ class CheckCpsIntegrity extends TrampolineRecursiveVisitor {

if (inScope[def] == ScopeType.NotInScope) {

error('Referenced out of scope: $def', ref);

}

+ if (ref.previous == ref) {

+ error('Shared Reference object to $def', ref);

+ }

if (ref.previous == null && def.firstRef != ref ||

ref.previous != null && ref.previous.next != ref) {

error('Broken .previous link in reference to $def', def);