dart2js cps: Refactor CallExpressions into Primitives.

pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library tree_ir_builder;
 
 import '../common.dart';
 import '../constants/values.dart';
 import '../cps_ir/cps_ir_nodes.dart' as cps_ir;
 import '../elements/elements.dart';
@@ skipping 99 matching lines @@
     if (thisParameter != null && reference.definition == thisParameter) {
       return new This();
     }
     return new VariableUse(getVariable(reference.definition));
   }
 
   Label getLabel(cps_ir.Continuation cont) {
     return labels.putIfAbsent(cont, () => new Label());
   }
 
-  Variable addFunctionParameter(cps_ir.Definition variable) {
-    if (variable is cps_ir.Parameter) {
-      return getVariable(variable);
-    } else {
-      return addMutableVariable(variable as cps_ir.MutableVariable)
-              ..isCaptured = true;
-    }
+  Variable addFunctionParameter(cps_ir.Parameter parameter) {
+    return getVariable(parameter);
   }
 
   FunctionDefinition buildFunction(cps_ir.FunctionDefinition node) {
     currentElement = node.element;
     if (parent != null) {
       // Local function's 'this' refers to enclosing method's 'this'
       thisParameter = parent.thisParameter;
     } else {
       thisParameter = node.thisParameter;
     }
@@ skipping 129 matching lines @@
     Statement result = node.accept(this); // Translate the tail expression.
     for (NodeCallback fun in stack.reversed) {
       result = fun(result);
     }
     return result;
   }
 
   /// Translates a CPS primitive to a tree expression.
   ///
   /// This simply calls the visit method for the primitive.
-  Expression translatePrimitive(cps_ir.Primitive prim) {
+  translatePrimitive(cps_ir.Primitive prim) {
     return prim.accept(this);
   }
 
   /************************ INTERIOR EXPRESSIONS  ************************/
   //
   // Visit methods for interior expressions must return a function:
   //
   //    (Statement next) => <result statement>
   //
 
-  NodeCallback visitLetPrim(cps_ir.LetPrim node) => (Statement next) {
+  NodeCallback visitLetPrim(cps_ir.LetPrim node) {
     Variable variable = getVariable(node.primitive);
-    Expression value = translatePrimitive(node.primitive);
-    if (node.primitive.hasAtLeastOneUse) {
-      return Assign.makeStatement(variable, value, next);
+    var value = translatePrimitive(node.primitive);
+    if (value is Expression) {
+      if (node.primitive.hasAtLeastOneUse) {
+        return (Statement next) => Assign.makeStatement(variable, value, next);
+      } else {
+        return (Statement next) => new ExpressionStatement(value, next);
+      }
     } else {
-      return new ExpressionStatement(value, next);
+      assert(value is NodeCallback);
+      return value;
     }
-  };
+  }
 
   // Continuations are bound at the same level, but they have to be
   // translated as if nested.  This is because the body can invoke any
   // of them from anywhere, so it must be nested inside all of them.
   //
   // The continuation bodies are not always translated directly here because
   // they may have been already translated:
   //   * For singly-used continuations, the continuation's body is
   //     translated at the site of the continuation invocation.
   //   * For recursive continuations, there is a single non-recursive
@@ skipping 26 matching lines @@
     return new Try(next, catchParameters, catchBody);
   };
 
   NodeCallback visitLetMutable(cps_ir.LetMutable node) {
     Variable variable = addMutableVariable(node.variable);
     Expression value = getVariableUse(node.value);
     return (Statement next) => Assign.makeStatement(variable, value, next);
   }
 
 
-  /************************ CALL EXPRESSIONS  ************************/
+  /*********** PRIMITIVES that used to be CALL EXPRESSIONS  ***************/
   //
-  // Visit methods for call expressions must return a function:
+  // Visit methods for primitives must return an expression or a NodeCallback.
   //
-  //    (Statement next) => <result statement>
+  // Section kept here to make the diff look nicer.
   //
-  // The result statement must include an assignment to the continuation
-  // parameter, if the parameter is used.
+  // FIXME(asgerf): Move down to other primitives.
   //
 
-  NodeCallback makeCallExpression(cps_ir.CallExpression call,
-                                  Expression expression) {
-    return (Statement next) {
-      cps_ir.Parameter result = call.continuation.definition.parameters.single;
-      if (result.hasAtLeastOneUse) {
-        return Assign.makeStatement(getVariable(result), expression, next);
-      } else {
-        return new ExpressionStatement(expression, next);
-      }
-    };
+  Expression visitInvokeStatic(cps_ir.InvokeStatic node) {
+    List<Expression> arguments = translateArguments(node.arguments);
+    return new InvokeStatic(node.target, node.selector, arguments,
+                                         node.sourceInformation);
   }
 
-  NodeCallback visitInvokeStatic(cps_ir.InvokeStatic node) {
-    List<Expression> arguments = translateArguments(node.arguments);
-    Expression invoke = new InvokeStatic(node.target, node.selector, arguments,
-                                         node.sourceInformation);
-    return makeCallExpression(node, invoke);
-  }
-
-  NodeCallback visitInvokeMethod(cps_ir.InvokeMethod node) {
+  Expression visitInvokeMethod(cps_ir.InvokeMethod node) {
     InvokeMethod invoke = new InvokeMethod(
         getVariableUse(node.receiver),
         node.selector,
         node.mask,
         translateArguments(node.arguments),
         node.sourceInformation);
     invoke.receiverIsNotNull = node.receiverIsNotNull;
-    return makeCallExpression(node, invoke);
+    return invoke;
   }
 
-  NodeCallback visitInvokeMethodDirectly(cps_ir.InvokeMethodDirectly node) {
+  Expression visitInvokeMethodDirectly(cps_ir.InvokeMethodDirectly node) {
     Expression receiver = getVariableUse(node.receiver);
     List<Expression> arguments = translateArguments(node.arguments);
-    Expression invoke = new InvokeMethodDirectly(receiver, node.target,
+    return new InvokeMethodDirectly(receiver, node.target,
         node.selector, arguments, node.sourceInformation);
-    return makeCallExpression(node, invoke);
   }
 
-  NodeCallback visitTypeCast(cps_ir.TypeCast node) {
+  Expression visitTypeCast(cps_ir.TypeCast node) {
     Expression value = getVariableUse(node.value);
     List<Expression> typeArgs = translateArguments(node.typeArguments);
-    Expression expression =
-        new TypeOperator(value, node.dartType, typeArgs, isTypeTest: false);
-    return makeCallExpression(node, expression);
+    return new TypeOperator(value, node.dartType, typeArgs, isTypeTest: false);
   }
 
-  NodeCallback visitInvokeConstructor(cps_ir.InvokeConstructor node) {
+  Expression visitInvokeConstructor(cps_ir.InvokeConstructor node) {
     List<Expression> arguments = translateArguments(node.arguments);
-    Expression invoke = new InvokeConstructor(
+    return new InvokeConstructor(
         node.dartType,
         node.target,
         node.selector,
         arguments,
         node.sourceInformation);
-    return makeCallExpression(node, invoke);
   }
 
-  NodeCallback visitForeignCode(cps_ir.ForeignCode node) {
+  visitForeignCode(cps_ir.ForeignCode node) {
     List<Expression> arguments =
         node.arguments.map(getVariableUse).toList(growable: false);
     if (HasCapturedArguments.check(node.codeTemplate.ast)) {
       for (Expression arg in arguments) {
         if (arg is VariableUse) {
           arg.variable.isCaptured = true;
         } else {
           // TODO(asgerf): Avoid capture of 'this'.
         }
       }
     }
     if (node.codeTemplate.isExpression) {
-      Expression foreignCode = new ForeignExpression(
+      return new ForeignExpression(
           node.codeTemplate,
           node.type,
           arguments,
           node.nativeBehavior,
           node.dependency);
-      return makeCallExpression(node, foreignCode);
     } else {
       return (Statement next) {
         assert(next is Unreachable); // We are not using the `next` statement.
         return new ForeignStatement(
             node.codeTemplate,
             node.type,
             arguments,
             node.nativeBehavior,
             node.dependency);
       };
     }
   }
 
-  NodeCallback visitGetLazyStatic(cps_ir.GetLazyStatic node) {
+  Expression visitGetLazyStatic(cps_ir.GetLazyStatic node) {
     // In the tree IR, GetStatic handles lazy fields because we do not need
     // as fine-grained control over side effects.
-    GetStatic value = new GetStatic(node.element, node.sourceInformation);
-    return makeCallExpression(node, value);
+    return new GetStatic(node.element, node.sourceInformation);
   }
 
   @override
   NodeCallback visitYield(cps_ir.Yield node) {
     return (Statement next) {
       return new Yield(getVariableUse(node.input), node.hasStar, next);
     };
   }
 
   @override
-  NodeCallback visitAwait(cps_ir.Await node) {
-    Expression value = new Await(getVariableUse(node.input));
-    return makeCallExpression(node, value);
+  Expression visitAwait(cps_ir.Await node) {
+    return new Await(getVariableUse(node.input));
   }
 
-
   /************************** TAIL EXPRESSIONS  **************************/
   //
   // Visit methods for tail expressions must return a statement directly
   // (not a function like interior and call expressions).
 
   Statement visitThrow(cps_ir.Throw node) {
     Expression value = getVariableUse(node.value);
     return new Throw(value);
   }
 
@@ skipping 261 matching lines @@
     --enclosingFunctions;
   }
 
   @override
   visitInterpolatedNode(js.InterpolatedNode node) {
     if (enclosingFunctions > 0) {
       found = true;
     }
   }
 }