Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2371)

Issue 1458703005: Make SkTLList prealloc its first block of nodes (Closed)

Created:
5 years, 1 month ago by bsalomon
Modified:
5 years, 1 month ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@nblock
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make SkTLList prealloc its first block of nodes Committed: https://skia.googlesource.com/skia/+/a7c41c5217da2f091ae78d002c9b92c20360ab87

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -7 lines) Patch
M src/core/SkTLList.h View 1 7 chunks +22 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
bsalomon
5 years, 1 month ago (2015-11-18 22:22:05 UTC) #2
joshualitt
On 2015/11/18 22:22:05, bsalomon wrote: lgtm
5 years, 1 month ago (2015-11-18 22:27:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458703005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458703005/1
5 years, 1 month ago (2015-11-19 03:06:59 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mips-Debug-Android-Trybot/builds/3569) Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 1 month ago (2015-11-19 03:07:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458703005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458703005/20001
5 years, 1 month ago (2015-11-19 03:36:44 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 03:48:52 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/a7c41c5217da2f091ae78d002c9b92c20360ab87

Powered by Google App Engine
This is Rietveld 408576698