Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1498)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java

Issue 1458703003: Media Session API: use MediaMetadata in the browser process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@media_session_browser_side
Patch Set: remove dependencies from other CLs Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java b/chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java
index 9864d7b4a7c49e0d91c2a2c06916b5eeba3eebe8..bb8ab9b481e780c6c6af37bc261479425c5da4de 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java
@@ -16,6 +16,7 @@ import org.chromium.chrome.browser.media.ui.MediaNotificationInfo;
import org.chromium.chrome.browser.media.ui.MediaNotificationListener;
import org.chromium.chrome.browser.media.ui.MediaNotificationManager;
import org.chromium.chrome.browser.tab.Tab;
+import org.chromium.content_public.common.MediaMetadata;
import javax.annotation.Nullable;
@@ -117,7 +118,7 @@ public class CastNotificationControl implements MediaRouteController.UiListener,
}
private void updateNotification() {
- mNotificationBuilder.setTitle(mTitle);
+ mNotificationBuilder.setMetadata(new MediaMetadata(mTitle, "", ""));
Ted C 2016/03/01 17:18:11 why the empty string and not null? Is there a req
mlamouri (slow - plz ping) 2016/03/16 15:47:15 The C++ class is using empty string as a default v
Ted C 2016/03/16 16:55:58 Acknowledged.
if (mState == PlayerState.PAUSED || mState == PlayerState.PLAYING) {
mNotificationBuilder.setPaused(mState != PlayerState.PLAYING);
mNotificationBuilder.setActions(MediaNotificationInfo.ACTION_STOP
@@ -208,4 +209,4 @@ public class CastNotificationControl implements MediaRouteController.UiListener,
boolean isShowingForTests() {
return mIsShowing;
}
-}
+}

Powered by Google App Engine
This is Rietveld 408576698