chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSessionImpl.java - Issue 1458703003: Media Session API: use MediaMetadata in the browser process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSessionImpl.java

Issue 1458703003: Media Session API: use MediaMetadata in the browser process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@media_session_browser_side

Patch Set: nits Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationInfo.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSessionImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSessionImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSessionImpl.java

index 47cdc4db30a65b90e07568022eac8109665009c2..2427eca5c2fec259723ac7bc1546834d080e1511 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSessionImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSessionImpl.java

@@ -22,6 +22,8 @@ import org.chromium.chrome.browser.media.ui.MediaNotificationInfo;

import org.chromium.chrome.browser.media.ui.MediaNotificationListener;

import org.chromium.chrome.browser.media.ui.MediaNotificationManager;

import org.chromium.chrome.browser.tab.Tab;

+import org.chromium.content_public.common.MediaMetadata;

import org.json.JSONException;

import org.json.JSONObject;

@@ -128,7 +130,7 @@ public class CastSessionImpl implements MediaNotificationListener, CastSession {

}

mNotificationBuilder = new MediaNotificationInfo.Builder()

- .setTitle(mCastDevice.getFriendlyName())

+ .setMetadata(new MediaMetadata(mCastDevice.getFriendlyName(), "", ""))

.setPaused(false)

.setOrigin(origin)

// TODO(avayvod): the same session might have more than one tab id. Should we track