Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: chrome/browser/extensions/api/storage/storage_schema_manifest_handler.h

Issue 14587009: Added a PolicyManifestHandler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/storage/storage_schema_manifest_handler.h
diff --git a/chrome/common/extensions/api/extension_action/page_action_handler.h b/chrome/browser/extensions/api/storage/storage_schema_manifest_handler.h
similarity index 51%
copy from chrome/common/extensions/api/extension_action/page_action_handler.h
copy to chrome/browser/extensions/api/storage/storage_schema_manifest_handler.h
index b623f6e361a8898b9e4b2c611551f5abe4ec8351..eda4f292821dd829ea3280d540f71b631e29c906 100644
--- a/chrome/common/extensions/api/extension_action/page_action_handler.h
+++ b/chrome/browser/extensions/api/storage/storage_schema_manifest_handler.h
@@ -2,34 +2,31 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_COMMON_EXTENSIONS_API_EXTENSION_ACTION_PAGE_ACTION_HANDLER_H_
-#define CHROME_COMMON_EXTENSIONS_API_EXTENSION_ACTION_PAGE_ACTION_HANDLER_H_
+#ifndef CHROME_BROWSER_EXTENSIONS_API_STORAGE_STORAGE_SCHEMA_MANIFEST_HANDLER_H_
+#define CHROME_BROWSER_EXTENSIONS_API_STORAGE_STORAGE_SCHEMA_MANIFEST_HANDLER_H_
-#include <string>
-
-#include "chrome/common/extensions/api/extension_action/action_info.h"
-#include "chrome/common/extensions/extension.h"
+#include "base/basictypes.h"
#include "chrome/common/extensions/manifest_handler.h"
namespace extensions {
-// Parses the "page_action" manifest key.
-class PageActionHandler : public ManifestHandler {
+// Handles the "storage.managed_schema" manifest key.
+class StorageSchemaManifestHandler : public ManifestHandler {
not at google - send to devlin 2013/05/23 16:56:18 bleh is there some way to tell git that this isn't
Joao da Silva 2013/05/24 21:31:49 Uploaded with --no-find-copies, let's see what it
public:
not at google - send to devlin 2013/05/23 16:56:18 pls quickly unit test the parsing here.
Joao da Silva 2013/05/24 21:31:49 Done.
- PageActionHandler();
- virtual ~PageActionHandler();
+ StorageSchemaManifestHandler();
+ virtual ~StorageSchemaManifestHandler();
+ // ManifestHandler implementation:
virtual bool Parse(Extension* extension, string16* error) OVERRIDE;
virtual bool Validate(const Extension* extension,
std::string* error,
std::vector<InstallWarning>* warnings) const OVERRIDE;
-
- private:
virtual const std::vector<std::string> Keys() const OVERRIDE;
not at google - send to devlin 2013/05/23 16:56:18 surely one or all of these can be private
Joao da Silva 2013/05/24 21:31:49 Done.
- DISALLOW_COPY_AND_ASSIGN(PageActionHandler);
+ private:
+ DISALLOW_COPY_AND_ASSIGN(StorageSchemaManifestHandler);
};
} // namespace extensions
-#endif // CHROME_COMMON_EXTENSIONS_API_EXTENSION_ACTION_PAGE_ACTION_HANDLER_H_
+#endif // CHROME_BROWSER_EXTENSIONS_API_STORAGE_STORAGE_SCHEMA_MANIFEST_HANDLER_H_

Powered by Google App Engine
This is Rietveld 408576698