Added a PolicyManifestHandler.

chrome/browser/extensions/api/storage/storage_schema_manifest_handler.cc

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/api/storage/storage_schema_manifest_handler.h"
+
+#include <string>
+#include <vector>
+
+#include "base/file_util.h"
+#include "base/files/file_path.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/string16.h"
+#include "base/stringprintf.h"
+#include "base/utf_string_conversions.h"
+#include "chrome/browser/policy/policy_schema.h"
+#include "chrome/common/extensions/extension.h"
+#include "chrome/common/extensions/extension_manifest_constants.h"
+#include "chrome/common/extensions/manifest.h"
+#include "chrome/common/extensions/permissions/api_permission.h"
+#include "extensions/common/install_warning.h"
+
+namespace extensions {
+
+namespace {
+
+const char kMissingPermission[] =
+    "The storage permission is required to use storage.managed_schema";
+const char kInvalidValue[] =
+    "Invalid value for storage.managed_schema - must be a string";

[not at google - send to devlin, 2013/05/23 16:56:18]

"storage.managed_schema must be a string"

[Joao da Silva, 2013/05/24 21:31:49]

Done.

+const char kInvalidPath[] =
+    "storage.managed_schema must be a relative path without ..";
+
+}  // namespace
+
+StorageSchemaManifestHandler::StorageSchemaManifestHandler() {}
+
+StorageSchemaManifestHandler::~StorageSchemaManifestHandler() {}
+
+bool StorageSchemaManifestHandler::Parse(Extension* extension,
+                                         string16* error) {
+  std::string path;
+  if (!extension->manifest()->GetString(
+          extension_manifest_keys::kStorageManagedSchema, &path)) {
+    *error = ASCIIToUTF16(kInvalidValue);
+    return false;
+  }
+  return true;
+}
+
+bool StorageSchemaManifestHandler::Validate(
+    const Extension* extension,
+    std::string* error,
+    std::vector<InstallWarning>* warnings) const {
+  if (!extension->HasAPIPermission(APIPermission::kStorage)) {

[not at google - send to devlin, 2013/05/23 16:56:18]

we should make the storage permission implied by the presence of the storage
manifest key, but until that's trivial:

https://codereview.chromium.org/15091002/
specifically
https://codereview.chromium.org/15091002/diff/32001/chrome/common/extensions/...

don't worry about it yet. but monitor it :) I'll try to remember to remind you
but it's likely I will fail.

[Joao da Silva, 2013/05/24 21:31:49]

I've cc'ed myself on that issue, I'll update this once that's in :-) Thanks for
the hint!

+    *error = kMissingPermission;
+    return false;
+  }
+  std::string path;
+  extension->manifest()->GetString(
+      extension_manifest_keys::kStorageManagedSchema, &path);
+  base::FilePath file = base::FilePath::FromUTF8Unsafe(path);
+  if (file.IsAbsolute() || file.ReferencesParent()) {
+    *error = kInvalidPath;
+    return false;
+  }
+  file = extension->path().AppendASCII(path);
+  if (!file_util::PathExists(file)) {
+    *error =
+        base::StringPrintf("File does not exist: %s", file.value().c_str());

[not at google - send to devlin, 2013/05/23 16:56:18]

"%s referenced by storage.managed_schema does not exist" %
(file.value().c_str())

would be nice to %s all of these hard-coded references to
storage.managed_schema, by the way.

[Joao da Silva, 2013/05/24 21:31:49]

Done.
Done.

+    return false;
+  }
+  std::string content;
+  if (!file_util::ReadFileToString(file, &content)) {
+    *error = base::StringPrintf("Can't read %s", file.value().c_str());
+    return false;
+  }
+  scoped_ptr<policy::PolicySchema> schema =
+      policy::PolicySchema::Parse(content, error);
+  return !!schema;
+}
+
+const std::vector<std::string> StorageSchemaManifestHandler::Keys() const {
+  return SingleKey(extension_manifest_keys::kStorageManagedSchema);
+}
+
+}  // namespace extensions