Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 1458683002: RTCVideoDecoder: add Destroy() static method for RTCVideoDecoderFactory (Closed)

Created:
5 years, 1 month ago by mcasas
Modified:
5 years, 1 month ago
Reviewers:
Pawel Osciak
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

RTCVideoDecoder: add Destroy() static method for RTCVideoDecoderFactory RTCVDFactory does not know where RTCVideoDecoder is created (it is created in one of the parameter's task runner), however it knows where to destroy it. Address this imbalance by offering an RTCVideoDecoder::Destroy() where the threading is explicit, since it lives next to RTCVideoDecoder::Create(). BUG=554737 TEST= tiny change, all unit tests passing. Committed: https://crrev.com/9fa42c24df5eb91352e1f1a7f0989007f3024b74 Cr-Commit-Position: refs/heads/master@{#360606}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M content/renderer/media/rtc_video_decoder.h View 1 chunk +5 lines, -2 lines 0 comments Download
M content/renderer/media/rtc_video_decoder.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/renderer/media/rtc_video_decoder_factory.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
mcasas
posciak@ PTAL (straightforward code shifting).
5 years, 1 month ago (2015-11-18 02:42:33 UTC) #2
Pawel Osciak
lgtm
5 years, 1 month ago (2015-11-19 08:59:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458683002/1
5 years, 1 month ago (2015-11-19 15:50:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 16:49:40 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 16:50:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9fa42c24df5eb91352e1f1a7f0989007f3024b74
Cr-Commit-Position: refs/heads/master@{#360606}

Powered by Google App Engine
This is Rietveld 408576698