Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 1458643002: Complete Stylus force & tilt info plumbing into JS. (Closed)

Created:
5 years, 1 month ago by mustaq
Modified:
5 years, 1 month ago
Reviewers:
haraken, Rick Byers
CC:
chromium-reviews, blink-reviews, blink-reviews-events_chromium.org, dglazkov+blink, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Complete stylus force & tilt info plumbing in blink. CromeOS now has low level support for stylus 3D orientation data (tiltX/tiltY) and force. For example, a Wacom Intuos Pro device with an Wacom Art Pen reports tiltX, tiltY & force info when attached to a ChromeBook Pixel. This CL completes the missing plumbing in blink so that the data is visible from JS. BUG=516706 Committed: https://crrev.com/5c63e884896fa1106b763297f6997b075867fd5e Cr-Commit-Position: refs/heads/master@{#360398}

Patch Set 1 #

Patch Set 2 : Cleaned up PlatformMouseEvent #

Patch Set 3 : Added TODOs for tests. #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties.html View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/mouse-pointer-event-properties-expected.txt View 1 2 3 13 chunks +0 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/events/PointerEvent.cpp View 1 3 chunks +10 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/PlatformMouseEvent.h View 1 3 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebInputEventConversion.cpp View 1 2 3 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
mustaq
ptal. This works smoothly in Pixel, wish we had this working before BlinkOn.
5 years, 1 month ago (2015-11-17 23:08:40 UTC) #4
Rick Byers
LGTM We should probably have some basic test coverage in WebInputEventConversionTest.cpp for this, but I ...
5 years, 1 month ago (2015-11-17 23:28:20 UTC) #5
mustaq
On 2015/11/17 23:28:20, Rick Byers (slow until Nov 23) wrote: > LGTM > > We ...
5 years, 1 month ago (2015-11-18 14:51:55 UTC) #6
mustaq
haraken@chromium.org: Please review changes in Source/{platform,web}.
5 years, 1 month ago (2015-11-18 14:52:43 UTC) #8
haraken
On 2015/11/18 14:52:43, mustaq wrote: > mailto:haraken@chromium.org: Please review changes in Source/{platform,web}. LGTM
5 years, 1 month ago (2015-11-18 15:00:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458643002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458643002/60001
5 years, 1 month ago (2015-11-18 15:09:20 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/142461)
5 years, 1 month ago (2015-11-18 16:58:06 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458643002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458643002/80001
5 years, 1 month ago (2015-11-18 18:42:44 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 1 month ago (2015-11-18 19:58:49 UTC) #18
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 20:00:30 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5c63e884896fa1106b763297f6997b075867fd5e
Cr-Commit-Position: refs/heads/master@{#360398}

Powered by Google App Engine
This is Rietveld 408576698