Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1458633003: X87: Rename original constructor to new target. (Closed)

Created:
5 years, 1 month ago by zhengxing.li
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Rename original constructor to new target. port 07c1d181e7d8ec838ea5f97e0514ce2a426b1f88 (r32023) original commit message: BUG= Committed: https://crrev.com/2772f1ceeff9d5b67540457cd49d0f045226396f Cr-Commit-Position: refs/heads/master@{#32067}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/builtins-x87.cc View 15 chunks +16 lines, -16 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
zhengxing.li
5 years, 1 month ago (2015-11-18 03:21:53 UTC) #2
Weiliang
lgtm
5 years, 1 month ago (2015-11-18 04:14:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458633003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458633003/1
5 years, 1 month ago (2015-11-18 04:14:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-18 04:32:17 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 04:32:40 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2772f1ceeff9d5b67540457cd49d0f045226396f
Cr-Commit-Position: refs/heads/master@{#32067}

Powered by Google App Engine
This is Rietveld 408576698