src/interpreter/bytecodes.h - Issue 1458603012: [Interpreter] Add CreateClosure to BytecodeGraphBuilder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/interpreter/bytecodes.h

Issue 1458603012: [Interpreter] Add CreateClosure to BytecodeGraphBuilder. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Revise CreateClosure bytecode per review and simplify unittest. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/interpreter/bytecodes.h

diff --git a/src/interpreter/bytecodes.h b/src/interpreter/bytecodes.h

index a142c1d739fada97da6320d55ee6dbe1fdb0e4f2..d30eec6947a7a06a4e01ddc4ecaf7cc8cdb49701 100644

--- a/src/interpreter/bytecodes.h

+++ b/src/interpreter/bytecodes.h

@@ -161,7 +161,8 @@ namespace interpreter {

V(CreateObjectLiteral, OperandType::kIdx8, OperandType::kImm8) \

/* Closure allocation */ \

- V(CreateClosure, OperandType::kImm8) \

+ V(CreateClosure, OperandType::kIdx8, OperandType::kImm8) \

+ V(CreateClosureWide, OperandType::kIdx16, OperandType::kImm8) \

/* Arguments allocation */ \

V(CreateMappedArguments, OperandType::kNone) \