[Interpreter] Add CreateClosure to BytecodeGraphBuilder.

src/compiler/bytecode-graph-builder.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/bytecode-graph-builder.h"
 
 #include "src/compiler/linkage.h"
+#include "src/compiler/node-matchers.h"
 #include "src/compiler/operator-properties.h"
 #include "src/interpreter/bytecode-array-iterator.h"
 
 namespace v8 {
 namespace internal {
 namespace compiler {
 
 // Issues:
 // - Need to deal with FrameState / FrameStateBeforeAndAfter / StateValue.
 // - Scopes - intimately tied to AST. Need to eval what is needed.
@@ skipping 618 matching lines @@
 
 
 void BytecodeGraphBuilder::VisitPopContext(
     const interpreter::BytecodeArrayIterator& iterator) {
   UNIMPLEMENTED();
 }
 
 
 void BytecodeGraphBuilder::VisitCreateClosure(
     const interpreter::BytecodeArrayIterator& iterator) {
-  UNIMPLEMENTED();
+  Node* accumulator = environment()->LookupAccumulator();
+  HeapObjectMatcher shared_info_matcher(accumulator);

[Benedikt Meurer, 2015/11/22 19:00:53]

Why do you need a HeapObjectMatcher at all here? The shared info should be a
literal for the CreateClosure bytecode and not an input.

[oth, 2015/11/22 21:43:58]

Just to clarify, is question suggesting the CreateClosure bytecode
be refined to include the literal rather than having the previous
bytecode load the value from the constant pool?

Current:
LdaConstant <constant_pool_index>
CreateClosure <pretenure_flag>

New:
CreateClosure <constant_pool_index> <pretenture_flag>

+  PretenureFlag pretenure =
+      iterator.GetImmediateOperand(0) ? TENURED : NOT_TENURED;
+  const Operator* op = javascript()->CreateClosure(
+      Handle<SharedFunctionInfo>::cast(shared_info_matcher.Value()), pretenure);
+  Node* closure = NewNode(op);
+  AddEmptyFrameStateInputs(closure);
+  environment()->BindAccumulator(closure);
 }
 
 
 void BytecodeGraphBuilder::VisitCreateMappedArguments(
     const interpreter::BytecodeArrayIterator& iterator) {
   UNIMPLEMENTED();
 }
 
 
 void BytecodeGraphBuilder::VisitCreateUnmappedArguments(
@@ skipping 571 matching lines @@
 
 void BytecodeGraphBuilder::UpdateControlDependencyToLeaveFunction(Node* exit) {
   if (environment()->IsMarkedAsUnreachable()) return;
   environment()->MarkAsUnreachable();
   exit_controls_.push_back(exit);
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8