Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1458603010: tools/gn: add python shebang directive to roll_gn script (Closed)

Created:
5 years, 1 month ago by tfarina
Modified:
5 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tools/gn: add python shebang directive to roll_gn script This way we can execute it from the command line like the following: $ ./tools/gn/bin/roll_gn.py Otherwise, on Linux you have to call python directly, like: $ python ./tools/gn/bin/roll_gn.py BUG=None TEST=see above R=dpranke@chromium.org TBR=brettw@chromium.org Committed: https://crrev.com/f7bc7c2c72c0d7f9bdb327154845b5baaf9ca72a Cr-Commit-Position: refs/heads/master@{#360620}

Patch Set 1 #

Patch Set 2 : set it executable - git update-index --chmod=+x tools/gn/bin/roll_gn.py - git diff --cached #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/gn/bin/roll_gn.py View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
tfarina
5 years, 1 month ago (2015-11-19 17:13:07 UTC) #2
Dirk Pranke
lgtm, but you need to make the file executable as well.
5 years, 1 month ago (2015-11-19 17:17:47 UTC) #3
tfarina
Done.
5 years, 1 month ago (2015-11-19 17:27:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458603010/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458603010/20001
5 years, 1 month ago (2015-11-19 17:27:51 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/120253)
5 years, 1 month ago (2015-11-19 17:39:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458603010/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458603010/20001
5 years, 1 month ago (2015-11-19 17:42:37 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-19 17:48:57 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 17:50:22 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f7bc7c2c72c0d7f9bdb327154845b5baaf9ca72a
Cr-Commit-Position: refs/heads/master@{#360620}

Powered by Google App Engine
This is Rietveld 408576698