Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1458603009: Revert of Add //components/signin/ios/browser:unit_tests to components_unittests. (Closed)

Created:
5 years, 1 month ago by miu
Modified:
5 years ago
Reviewers:
Dirk Pranke, sdefresne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@ios_provider_chrome
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add //components/signin/ios/browser:unit_tests to components_unittests. (patchset #2 id:20001 of https://codereview.chromium.org/1441353003/ ) Reason for revert: This patch set very likely broke all the tab_capture_end2end_tests on Mac. I am reverting this AND the change the sheriff made (which disabled the failing tests): https://codereview.chromium.org/1456863003/ See http://crbug.com/557929 for more details. Original issue's description: > Add //components/signin/ios/browser:unit_tests to components_unittests. > > Fix an incorrect dependency in the BUILD.gn file and add deps to > the targets in //components/BUILD.gn. > > Add a reference to gn target in //components/sessions.gypi. > > BUG=459705 > > Committed: https://crrev.com/06332e60d4928fee0cfa695cd55b3eab8f31a26a > Cr-Commit-Position: refs/heads/master@{#360320} TBR=dpranke@chromium.org,sdefresne@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=459705

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M components/BUILD.gn View 6 chunks +2 lines, -4 lines 0 comments Download
M components/sessions.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/signin/ios/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
miu
Created Revert of Add //components/signin/ios/browser:unit_tests to components_unittests.
5 years, 1 month ago (2015-11-19 02:50:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458603009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458603009/1
5 years, 1 month ago (2015-11-19 02:51:06 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 02:52:26 UTC) #5
Failed to apply patch for components/BUILD.gn:
While running git apply --index -3 -p1;
  error: patch failed: components/BUILD.gn:53
  Falling back to three-way merge...
  Applied patch to 'components/BUILD.gn' with conflicts.
  U components/BUILD.gn

Patch:       components/BUILD.gn
Index: components/BUILD.gn
diff --git a/components/BUILD.gn b/components/BUILD.gn
index
505988d5b16859b4ed9f6ab2fdd5a4c836df541e..e4e2c61855327befc20f5c0111686ae6a7b8e04c
100644
--- a/components/BUILD.gn
+++ b/components/BUILD.gn
@@ -53,7 +53,6 @@
     "//components/pref_registry",
     "//components/omnibox/browser",
     "//components/infobars/core",
-    "//components/signin/core/browser",
     "//components/translate/core/browser",
     "//components/translate/core/common",
     "//components/version_ui",
@@ -134,6 +133,7 @@
       "//components/safe_browsing_db",
       "//components/search_provider_logos",
       "//components/security_interstitials/core",
+      "//components/signin/core/browser",
       "//components/ssl_config",
       "//components/startup_metric_utils/common",
       "//components/startup_metric_utils/browser",
@@ -228,7 +228,6 @@
       "//components/dom_distiller/ios",
       "//components/history/ios/browser",
       "//components/keyed_service/ios",
-      "//components/signin/ios/browser",
       "//components/translate/ios/browser",
       "//components/webp_transcode",
     ]
@@ -357,7 +356,6 @@
     "//components/search_engines:unit_tests",
     "//components/undo:unit_tests",
     "//components/leveldb_proto:unit_tests",
-    "//components/signin/core/browser:unit_tests",
     "//components/suggestions:unit_tests",
     "//components/translate/core/browser:unit_tests",
     "//components/translate/core/common:unit_tests",
@@ -431,6 +429,7 @@
       "//components/search_engines:unit_tests",
       "//components/search:unit_tests",
       "//components/search_provider_logos:unit_tests",
+      "//components/signin/core/browser:unit_tests",
       "//components/ssl_config:unit_tests",
       "//components/sync_bookmarks:unit_tests",
       "//components/sync_driver:unit_tests",
@@ -509,7 +508,6 @@
     }
   } else {
     deps += [
-      "//components/signin/ios/browser:unit_tests",
       "//components/translate/ios/browser:unit_tests",
       "//components/webp_transcode:unit_tests",
     ]

Powered by Google App Engine
This is Rietveld 408576698