Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1458603006: In BUILD.public, remove compile-time dependency on GL. (Closed)

Created:
5 years, 1 month ago by dogben
Modified:
5 years, 1 month ago
Reviewers:
mtklein
CC:
jcgregorio, reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

In BUILD.public, remove compile-time dependency on GL. BUG=skia: Committed: https://skia.googlesource.com/skia/+/a445cbccefb018b8163aae0a0c0a19c850a39be5

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -23 lines) Patch
M BUILD.public View 6 chunks +2 lines, -8 lines 0 comments Download
M tools/BUILD.public.expected View 10 chunks +7 lines, -15 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458603006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458603006/1
5 years, 1 month ago (2015-11-18 21:29:01 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458603006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458603006/20001
5 years, 1 month ago (2015-11-18 21:31:46 UTC) #5
dogben
5 years, 1 month ago (2015-11-18 21:32:48 UTC) #7
mtklein
lgtm
5 years, 1 month ago (2015-11-18 21:35:44 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-18 21:46:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458603006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458603006/20001
5 years, 1 month ago (2015-11-18 21:48:09 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 21:48:49 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:20001) as
https://skia.googlesource.com/skia/+/a445cbccefb018b8163aae0a0c0a19c850a39be5

Powered by Google App Engine
This is Rietveld 408576698