Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1458553006: ScopedPtrMap -> std::map from apps, ash, media, ui (Closed)

Created:
5 years, 1 month ago by limasdf
Modified:
5 years, 1 month ago
CC:
chromium-reviews, Peter Beverloo, feature-media-reviews_chromium.org, cc-bugs_chromium.org, mlamouri+watch-notifications_chromium.org, toyoshim+midi_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ScopedPtrMap -> std::map from apps, ash, media, ui C++ 11 enables containers that contain move-only type, scoped_ptr. So, Use std::map<key, scoped_ptr<Foo>> instead of ScopedPtrMap. Also use std::move() instead of scoped_ptr::Pass(). TBR=avi@chromium.org BUG=554291, 557422 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/918cc2e94b4592f9211390784de4bb8534b59cc4 Cr-Commit-Position: refs/heads/master@{#360745}

Patch Set 1 : #

Patch Set 2 : fix compile #

Patch Set 3 : Fix ash_unittests compile error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -27 lines) Patch
M apps/saved_files_service.h View 2 chunks +2 lines, -3 lines 0 comments Download
M apps/saved_files_service.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/system/chromeos/power/tray_power_unittest.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M media/midi/midi_manager_alsa.h View 4 chunks +4 lines, -6 lines 0 comments Download
M media/midi/midi_manager_alsa.cc View 5 chunks +6 lines, -4 lines 0 comments Download
M ui/message_center/popup_timer.h View 2 chunks +2 lines, -3 lines 0 comments Download
M ui/message_center/popup_timer.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 27 (15 generated)
limasdf
Please take a look. it's fairly mechanical.
5 years, 1 month ago (2015-11-19 02:02:23 UTC) #8
oshima
ash lgtm
5 years, 1 month ago (2015-11-19 02:03:21 UTC) #9
xhwang
media lgtm
5 years, 1 month ago (2015-11-19 06:32:07 UTC) #10
benwells
lgtm
5 years, 1 month ago (2015-11-19 19:17:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458553006/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458553006/120001
5 years, 1 month ago (2015-11-19 23:05:01 UTC) #15
Avi (use Gerrit)
lgtm
5 years, 1 month ago (2015-11-19 23:14:27 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, no build URL)
5 years, 1 month ago (2015-11-19 23:30:50 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458553006/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458553006/120001
5 years, 1 month ago (2015-11-20 01:39:30 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/123258) linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 1 month ago (2015-11-20 01:59:55 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458553006/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458553006/140001
5 years, 1 month ago (2015-11-20 02:24:02 UTC) #25
commit-bot: I haz the power
Committed patchset #3 (id:140001)
5 years, 1 month ago (2015-11-20 04:29:05 UTC) #26
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 04:30:13 UTC) #27
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/918cc2e94b4592f9211390784de4bb8534b59cc4
Cr-Commit-Position: refs/heads/master@{#360745}

Powered by Google App Engine
This is Rietveld 408576698