Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1458553005: Add variant of check-layout.js that uses testharness.js (Closed)

Created:
5 years, 1 month ago by jsbell
Modified:
5 years, 1 month ago
Reviewers:
cbiesinger, eae, ojan
CC:
chromium-reviews, blink-reviews, cbiesinger
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

With an eye towards upstreaming css3/flexbox and other tests, enable check-layout.js to be used with testharness.js. This CL adds a copy (check-layout-ht.js) and modifies two sample tests (one passing, one with failures). The remaining tests can be updated incrementally, and then the duplicate script can be retired. R=eae@chromium.org BUG=554650 Committed: https://crrev.com/e79246a5bce938b91dc3793044c4dd9371a72d6a Cr-Commit-Position: refs/heads/master@{#360622}

Patch Set 1 #

Patch Set 2 : Better test names #

Patch Set 3 : Better error output, remove dead code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -32 lines) Patch
M third_party/WebKit/LayoutTests/css3/flexbox/flexitem.html View 1 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/css3/flexbox/flexitem-expected.txt View 1 2 1 chunk +26 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/flexbox/stretched-child-shrink-on-relayout.html View 1 1 chunk +3 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/css3/flexbox/stretched-child-shrink-on-relayout-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
A third_party/WebKit/LayoutTests/resources/check-layout-th.js View 1 2 1 chunk +190 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
jsbell
Please take a look? (I'm happy to convert more of the tests over in this ...
5 years, 1 month ago (2015-11-18 23:23:54 UTC) #3
jsbell
Actually, hold off on review - I can improve the failure messages, and there's still ...
5 years, 1 month ago (2015-11-18 23:29:52 UTC) #4
jsbell
Not perfect but this is better. PTAL?
5 years, 1 month ago (2015-11-18 23:41:29 UTC) #5
eae
Step in the right direction, LGTM
5 years, 1 month ago (2015-11-19 00:47:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458553005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458553005/40001
5 years, 1 month ago (2015-11-19 17:11:53 UTC) #11
jsbell
On 2015/11/19 00:47:41, eae wrote: > Step in the right direction Thanks. I'll land more ...
5 years, 1 month ago (2015-11-19 17:28:32 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-19 17:54:48 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 17:55:36 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e79246a5bce938b91dc3793044c4dd9371a72d6a
Cr-Commit-Position: refs/heads/master@{#360622}

Powered by Google App Engine
This is Rietveld 408576698