Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 14585015: Recommit the generate profile patch (Closed)

Created:
7 years, 7 months ago by Elliot Glaysher
Modified:
7 years, 7 months ago
CC:
chromium-reviews, chrome-speed-team+watch_google.com, browser-components-watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Rebuild test history databases when starting up performance_ui_tests. [In this reland, manually load the browser dll as a resource on Windows.] Previously, whenever the theme or history database format were modified, a large binary database or pak file had to be committed. This was only done intermittently, messing up some perf expectations. Since last June, this has added over 100 megabytes to our repository weight. By generating the SQLite databases and Cached Theme.pak files at startup of the one test suite that uses them, we're guaranteed that we'll always be using the current versions and won't add upgrade costs to our performance_ui_tests. We'll also not continuously add to new binary resources to the permanent git archive. BUG=111570 TBR=sky@chromium.org First Review: https://codereview.chromium.org/14273023 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200094

Patch Set 1 #

Patch Set 2 : Load the browser dll manually on Windows. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+432 lines, -543 lines) Patch
M chrome/browser/history/history_types.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history_unittest.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M chrome/browser/history/top_sites.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/history/top_sites_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/top_sites_impl.h View 3 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/history/top_sites_impl.cc View 5 chunks +43 lines, -7 lines 0 comments Download
M chrome/browser/history/top_sites_likely_impl.h View 3 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/history/top_sites_likely_impl.cc View 5 chunks +43 lines, -7 lines 0 comments Download
M chrome/chrome_tests.gypi View 6 chunks +24 lines, -45 lines 0 comments Download
D chrome/test/data/profiles/profile_with_complex_theme/Default/Cookies View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/profile_with_complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/Cached Theme.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/profile_with_complex_theme/Default/Full Text Index View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/profile_with_complex_theme/Default/History View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/profile_with_complex_theme/Default/History Index 2013-01 View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/profile_with_complex_theme/Default/History Index 2013-01-journal View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/profile_with_complex_theme/Default/History Provider Cache View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/profile_with_complex_theme/Default/History-journal View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/test/data/profiles/profile_with_complex_theme/Default/PreferencesTemplate View 1 chunk +2 lines, -1 line 0 comments Download
D chrome/test/data/profiles/profile_with_complex_theme/Default/Visited Links View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/profile_with_default_theme/Default/Archived History View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/profile_with_default_theme/Default/Archived History-journal View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/profile_with_default_theme/Default/Favicons View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/profile_with_default_theme/Default/Favicons-journal View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/profile_with_default_theme/Default/History View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/profile_with_default_theme/Default/History Index 2013-02 View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/profile_with_default_theme/Default/History Index 2013-02-journal View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/profile_with_default_theme/Default/History Provider Cache View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/profile_with_default_theme/Default/History-journal View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/profile_with_default_theme/Default/Top Sites View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/profile_with_default_theme/Default/Top Sites-journal View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/profile_with_default_theme/Default/Visited Links View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/profile_with_default_theme/README.txt View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/test/perf/feature_startup_test.cc View 4 chunks +11 lines, -12 lines 0 comments Download
A chrome/test/perf/generate_profile.h View 1 chunk +29 lines, -0 lines 0 comments Download
A + chrome/test/perf/generate_profile.cc View 9 chunks +36 lines, -74 lines 0 comments Download
A chrome/test/perf/perf_ui_test_suite.h View 1 chunk +45 lines, -0 lines 0 comments Download
A chrome/test/perf/perf_ui_test_suite.cc View 1 1 chunk +174 lines, -0 lines 0 comments Download
A + chrome/test/perf/run_all_perfuitests.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/test/perf/startup_test.cc View 7 chunks +18 lines, -14 lines 0 comments Download
M chrome/test/ui/ui_test.h View 3 chunks +0 lines, -13 lines 0 comments Download
M chrome/test/ui/ui_test.cc View 3 chunks +2 lines, -27 lines 0 comments Download
D chrome/tools/profiles/generate_profile.cc View 1 chunk +0 lines, -310 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Elliot Glaysher
sky: All the differences are in patchset 2, in the file chrome/test/perf/perf_ui_test_suite.cc. That code is ...
7 years, 7 months ago (2013-05-14 20:48:05 UTC) #1
sky
LGTM
7 years, 7 months ago (2013-05-14 21:12:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/14585015/2001
7 years, 7 months ago (2013-05-14 22:42:22 UTC) #3
commit-bot: I haz the power
Can't process patch for file chrome/test/data/profiles/profile_with_default_theme/Default/History Index 2013-02-journal. Unexpected git diff output name Index 2013-02-journal ...
7 years, 7 months ago (2013-05-14 22:42:26 UTC) #4
Elliot Glaysher
Committed patchset #2 manually as r200094 (presubmit successful).
7 years, 7 months ago (2013-05-14 22:58:58 UTC) #5
Elliot Glaysher
7 years, 7 months ago (2013-05-14 23:01:32 UTC) #6
Message was sent while issue was closed.
On 2013/05/14 22:58:58, Elliot Glaysher wrote:
> Committed patchset #2 manually as r200094 (presubmit successful).

(Note: Because of the failure both on Windows and the CQ refusing to process the
patch, the change was recreated locally on my linux box and dcommitted there.)

Powered by Google App Engine
This is Rietveld 408576698