Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Issue 1458463002: Add some missing null checks in chromevox next. (Closed)

Created:
5 years, 1 month ago by Peter Lundblad
Modified:
5 years, 1 month ago
Reviewers:
dmazzoni, David Tseng
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add some missing null checks in chromevox next. BUG=None TESTED=chromevox_tests R=dtseng@chromium.org Committed: https://crrev.com/2f24c2e8ef80d28e13fd139f46f43c78e4b2e4d3 Cr-Commit-Position: refs/heads/master@{#360621}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Change the logic in one if statement. #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 1 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
Peter Lundblad
5 years, 1 month ago (2015-11-17 14:40:29 UTC) #1
David Tseng
 https://codereview.chromium.org/1458463002/diff/1/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js File chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js (right): https://codereview.chromium.org/1458463002/diff/1/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js#newcode600 chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:600: if (!this.currentRange_ || this.currentRange_ &&
5 years, 1 month ago (2015-11-17 19:06:25 UTC) #2
Peter Lundblad
dtseng@chromium.org writes: >  > > > https://codereview.chromium.org/1458463002/diff/1/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js > File > chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js > (right): > ...
5 years, 1 month ago (2015-11-18 10:47:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458463002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458463002/40001
5 years, 1 month ago (2015-11-18 11:09:03 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 1 month ago (2015-11-18 11:09:04 UTC) #7
Peter Lundblad
PTAL
5 years, 1 month ago (2015-11-19 13:13:51 UTC) #8
dmazzoni
lgtm
5 years, 1 month ago (2015-11-19 17:25:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458463002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458463002/40001
5 years, 1 month ago (2015-11-19 17:26:38 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-19 17:49:52 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 17:51:29 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2f24c2e8ef80d28e13fd139f46f43c78e4b2e4d3
Cr-Commit-Position: refs/heads/master@{#360621}

Powered by Google App Engine
This is Rietveld 408576698