mojo/services/vsync/interfaces/vsync.mojom - Issue 1458453003: Add mojo service to get notified of vsync.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mojo/services/vsync/interfaces/vsync.mojom

Issue 1458453003: Add mojo service to get notified of vsync. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Add comment Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 [DartPackage="mojo_services"]	5 [DartPackage="mojo_services"]

6 module icu_data;	6 module vsync;

7	7

8 interface ICUData {	8 interface VSyncProvider {

9 Map(string sha1hash) => (handle<shared_buffer>? icu_data);	9 // Timebase is in MojoGetTimeTicksNow.
	ppi 2015/11/17 16:40:46 Please document what this does. E.g. Waits for th Please document what this does. E.g. Waits for the next vsync and returns its timestamp once it happens. ppi 2015/11/17 16:40:46 The source of this timestamp is actually not MojoG The source of this timestamp is actually not MojoGetTimeTicksNow(), we get this from the OS and it represents time "since boot, not counting time spent in deep sleep.". Is this in line with what we use for mojo timeticks on Android? qsr 2015/11/17 17:19:40 Done. Show quoted text On 2015/11/17 16:40:46, ppi wrote: > Please document what this does. > > E.g. Waits for the next vsync and returns its timestamp once it happens. Done. qsr 2015/11/17 17:19:40 Removed any reference of the timestamp, saying tha Show quoted text On 2015/11/17 16:40:46, ppi wrote: > The source of this timestamp is actually not MojoGetTimeTicksNow(), we get this > from the OS and it represents time "since boot, not counting time spent in deep > sleep.". Is this in line with what we use for mojo timeticks on Android? Removed any reference of the timestamp, saying that it can only be compared with other calls of this method.
	10 // Only one callback can be parked at a given time.

	11 AwaitVSync() => (int64 time_stamp);

10 };	12 };

OLD	NEW

« no previous file with comments | « mojo/services/vsync/interfaces/BUILD.gn ('k') | services/vsync/BUILD.gn » ('j') | services/vsync/src/org/chromium/mojo/vsync/VSyncProviderImpl.java » ('J')