Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1458423002: [turbofan] Renamed the ChangeFloat64ToInt64 operator to TruncateFloat64ToInt64. (Closed)

Created:
5 years, 1 month ago by ahaas
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer, titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Renamed the ChangeFloat64ToInt64 operator to TruncateFloat64ToInt64. R=titzer@chromium.org Committed: https://crrev.com/a2449d49851d0a9c9a36c077ccc61827510c3ac4 Cr-Commit-Position: refs/heads/master@{#32139}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/instruction-selector.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/machine-operator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/machine-operator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/verifier.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ahaas
5 years, 1 month ago (2015-11-20 09:29:22 UTC) #1
titzer
On 2015/11/20 09:29:22, ahaas wrote: lgtm
5 years, 1 month ago (2015-11-20 09:35:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458423002/1
5 years, 1 month ago (2015-11-20 09:39:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-20 09:47:06 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 09:47:40 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a2449d49851d0a9c9a36c077ccc61827510c3ac4
Cr-Commit-Position: refs/heads/master@{#32139}

Powered by Google App Engine
This is Rietveld 408576698