Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1458403002: Oilpan: Mention pre-finalizer registration in the documentation. (Closed)

Created:
5 years, 1 month ago by Yuta Kitamura
Modified:
5 years ago
CC:
chromium-reviews, blink-reviews, kouhei+heap_chromium.org, oilpan-reviews, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: Mention pre-finalizer registration in the documentation. BUG=544756 R=haraken@chromium.org, keishi@chromium.org, oilpan-reviews@chromium.org Committed: https://crrev.com/80555a9c9a1ac14be98fe562f75be9fc1bfeeaef Cr-Commit-Position: refs/heads/master@{#360784}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/heap/BlinkGCAPIReference.md View 1 chunk +7 lines, -0 lines 2 comments Download

Messages

Total messages: 9 (2 generated)
Yuta Kitamura
5 years, 1 month ago (2015-11-20 07:06:45 UTC) #1
haraken
LGTM
5 years, 1 month ago (2015-11-20 08:05:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458403002/1
5 years, 1 month ago (2015-11-20 08:12:42 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-20 08:53:59 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/80555a9c9a1ac14be98fe562f75be9fc1bfeeaef Cr-Commit-Position: refs/heads/master@{#360784}
5 years, 1 month ago (2015-11-20 08:55:02 UTC) #6
sof
https://codereview.chromium.org/1458403002/diff/1/third_party/WebKit/Source/platform/heap/BlinkGCAPIReference.md File third_party/WebKit/Source/platform/heap/BlinkGCAPIReference.md (right): https://codereview.chromium.org/1458403002/diff/1/third_party/WebKit/Source/platform/heap/BlinkGCAPIReference.md#newcode110 third_party/WebKit/Source/platform/heap/BlinkGCAPIReference.md:110: ThreadState::current()->registerPreFinalizer(this, dispose); ThreadState::registerPreFinalizer() doesn't take two arguments (any longer.)
5 years, 1 month ago (2015-11-21 16:11:36 UTC) #8
Yuta Kitamura
5 years ago (2015-11-24 07:07:59 UTC) #9
Message was sent while issue was closed. 
https://codereview.chromium.org/1458403002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/heap/BlinkGCAPIReference.md (right):

https://codereview.chromium.org/1458403002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/heap/BlinkGCAPIReference.md:110:
ThreadState::current()->registerPreFinalizer(this, dispose);
On 2015/11/21 16:11:36, sof wrote:
> ThreadState::registerPreFinalizer() doesn't take two arguments (any longer.)

Whoops, thanks. I'll follow-up with this.

(Comments in ThreadState.h also have two arguments version of this
 function, which I'll fix up together.)

Powered by Google App Engine
This is Rietveld 408576698