Add constant CPDFSDK_InterForm::kNumFieldTypes

fpdfsdk/src/fsdk_baseform.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "fpdfsdk/include/formfiller/FFL_FormFiller.h"
 #include "fpdfsdk/include/fsdk_actionhandler.h"
 #include "fpdfsdk/include/fsdk_baseannot.h"
 #include "fpdfsdk/include/fsdk_baseform.h"
@@ skipping 1501 matching lines @@
 CPDFSDK_InterForm::CPDFSDK_InterForm(CPDFSDK_Document* pDocument)
     : m_pDocument(pDocument),
       m_pInterForm(NULL),
       m_bCalculate(TRUE),
       m_bBusy(FALSE) {
   ASSERT(m_pDocument != NULL);
   m_pInterForm = new CPDF_InterForm(m_pDocument->GetDocument(), FALSE);
   ASSERT(m_pInterForm != NULL);
   m_pInterForm->SetFormNotify(this);
 
-  for (int i = 0; i < 6; i++)
+  for (int i = 0; i < kNumFieldTypes; ++i)
     m_bNeedHightlight[i] = FALSE;
   m_iHighlightAlpha = 0;
 }
 
 CPDFSDK_InterForm::~CPDFSDK_InterForm() {
   delete m_pInterForm;
   m_pInterForm = nullptr;
   m_Map.clear();
 }
 
@@ skipping 699 matching lines @@
 int CPDFSDK_InterForm::BeforeFormImportData(const CPDF_InterForm* pForm) {
   return 0;
 }
 
 int CPDFSDK_InterForm::AfterFormImportData(const CPDF_InterForm* pForm) {
   OnCalculate(nullptr);
   return 0;
 }
 
 FX_BOOL CPDFSDK_InterForm::IsNeedHighLight(int nFieldType) {
-  if (nFieldType < 1 || nFieldType > 6)
+  if (nFieldType < 1 || nFieldType > kNumFieldTypes)
     return FALSE;
   return m_bNeedHightlight[nFieldType - 1];
 }
 
 void CPDFSDK_InterForm::RemoveAllHighLight() {
-  memset((void*)m_bNeedHightlight, 0, 6 * sizeof(FX_BOOL));
+  for (int i = 0; i < kNumFieldTypes; ++i)
+    m_bNeedHightlight[i] = FALSE;
 }
+
 void CPDFSDK_InterForm::SetHighlightColor(FX_COLORREF clr, int nFieldType) {
-  if (nFieldType < 0 || nFieldType > 6)
+  if (nFieldType < 0 || nFieldType > kNumFieldTypes)
     return;
   switch (nFieldType) {
     case 0: {
-      for (int i = 0; i < 6; i++) {
+      for (int i = 0; i < kNumFieldTypes; ++i) {
         m_aHighlightColor[i] = clr;
         m_bNeedHightlight[i] = TRUE;
       }
       break;
     }
     default: {
       m_aHighlightColor[nFieldType - 1] = clr;
       m_bNeedHightlight[nFieldType - 1] = TRUE;
       break;
     }
   }
 }
 
 FX_COLORREF CPDFSDK_InterForm::GetHighlightColor(int nFieldType) {
-  if (nFieldType < 0 || nFieldType > 6)
+  if (nFieldType < 0 || nFieldType > kNumFieldTypes)
     return FXSYS_RGB(255, 255, 255);
   if (nFieldType == 0)
     return m_aHighlightColor[0];
   return m_aHighlightColor[nFieldType - 1];
 }
 
 /* ------------------------- CBA_AnnotIterator ------------------------- */
 
 CBA_AnnotIterator::CBA_AnnotIterator(CPDFSDK_PageView* pPageView,
                                      const CFX_ByteString& sType,
@@ skipping 216 matching lines @@
       break;
     }
   }
 }
 
 CPDF_Rect CBA_AnnotIterator::GetAnnotRect(CPDFSDK_Annot* pAnnot) {
   CPDF_Rect rcAnnot;
   pAnnot->GetPDFAnnot()->GetRect(rcAnnot);
   return rcAnnot;
 }