Issue 1458363005: Add constant CPDFSDK_InterForm::kNumFieldTypes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1458363005: Add constant CPDFSDK_InterForm::kNumFieldTypes (Closed)

Created:
5 years, 1 month ago by Tom Sepez

Modified:
5 years, 1 month ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Add constant CPDFSDK_InterForm::kNumFieldTypes Bumping this one line from 6 to 7 in XFA saves a bunch of diffs. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/7711b60efc62db14748711727560367d948745f1

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -8 lines)			Patch
	M	fpdfsdk/include/fsdk_baseform.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
	M	fpdfsdk/src/fsdk_baseform.cpp	View		3 chunks	+8 lines, -6 lines	0 comments	Download

Total messages: 6 (1 generated)

Tom Sepez

5 years, 1 month ago (2015-11-20 23:15:39 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7711b60efc62db14748711727560367d948745f1 (presubmit successful).