Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 1458363003: Remove extraneous SubtreeStyleChange for min/maxlength changes. (Closed)

Created:
5 years, 1 month ago by rune
Modified:
5 years ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove extraneous SubtreeStyleChange for min/maxlength changes. Validation already takes care of :valid/:invalid changes through invalidation sets. This reduces the number of elements being recalculated and gets rid of a SubtreeStyleChange which relies on sibling tree recalcs. R=tkent@chromium.org BUG=557440 Committed: https://crrev.com/81fb8abcd74847f62bf89e45e6dda0c7464e08c4 Cr-Commit-Position: refs/heads/master@{#361123}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/fast/css/invalidation/valid-invalid-pseudo.html View 3 chunks +36 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/invalidation/valid-invalid-pseudo-expected.txt View 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
rune
ptal
5 years, 1 month ago (2015-11-20 13:32:51 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458363003/1
5 years, 1 month ago (2015-11-20 13:33:25 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-20 14:45:54 UTC) #5
tkent
lgtm
5 years ago (2015-11-23 14:44:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458363003/1
5 years ago (2015-11-23 14:50:34 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-23 16:30:13 UTC) #9
commit-bot: I haz the power
5 years ago (2015-11-23 16:31:13 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/81fb8abcd74847f62bf89e45e6dda0c7464e08c4
Cr-Commit-Position: refs/heads/master@{#361123}

Powered by Google App Engine
This is Rietveld 408576698