Port ChromeSyncShell build rules to GN

chrome/android/chrome_apk.gyp

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 {
   'includes': [
     '../../chrome/chrome_android_paks.gypi', # Included for the list of pak resources.
     '../../build/util/version.gypi'
    ],
   'variables': {
     'chromium_code': 1,
     'package_name': 'chrome_public_apk',
     'manifest_package': 'org.chromium.chrome',
     'sync_shell_manifest_package': 'org.chromium.chrome.sync_shell',
     'chrome_public_apk_manifest': '<(SHARED_INTERMEDIATE_DIR)/chrome_public_apk_manifest/AndroidManifest.xml',
     'chrome_public_test_apk_manifest': '<(SHARED_INTERMEDIATE_DIR)/chrome_public_test_apk_manifest/AndroidManifest.xml',
     'chrome_sync_shell_apk_manifest': '<(SHARED_INTERMEDIATE_DIR)/chrome_sync_shell_apk_manifest/AndroidManifest.xml',
     'chrome_sync_shell_test_apk_manifest': '<(SHARED_INTERMEDIATE_DIR)/chrome_sync_shell_test_apk_manifest/AndroidManifest.xml',
     # This list is shared with GN.
     # Defines a list of source files should be present in the open-source
     # chrome-apk but not in the published static_library which is included in the
     # real chrome for android.
     'chrome_public_app_native_sources': [
       '../app/android/chrome_main_delegate_android_initializer.cc',
       '../browser/android/chrome_entry_point.cc',
     ],
+
+    # This list is shared with GN.
+    'chrome_sync_shell_app_native_sources': [
+      '../browser/android/chrome_entry_point.cc',
+      '../browser/android/chrome_sync_shell_main_delegate_initializer.cc',
+      '../browser/android/chrome_sync_shell_main_delegate.h',
+      '../browser/android/chrome_sync_shell_main_delegate.cc',
+    ]
   },
   'targets': [
     {
-      #GN: //chrome/android::custom_tabs_service_aidl
+      # GN: //chrome/android::custom_tabs_service_aidl
       'target_name': 'custom_tabs_service_aidl',
       'type': 'none',
       'variables': {
         'aidl_interface_file': 'java/src/android/support/customtabs/common.aidl',
         'aidl_import_include': 'java/src/android/support/customtabs',
       },
       'sources': [
         'java/src/android/support/customtabs/ICustomTabsCallback.aidl',
         'java/src/android/support/customtabs/ICustomTabsService.aidl',
       ],
       'includes': [ '../../build/java_aidl.gypi' ],
     },
     {
-      # GN: //chrome/android:chrome_public_template_resources
-      'target_name': 'chrome_public_template_resources',
+      # GN: //chrome/android:chrome_public_apk_template_resources
+      'target_name': 'chrome_public_apk_template_resources',
       'type': 'none',
       'variables': {
         'jinja_inputs_base_dir': 'java/res_template',
         'jinja_inputs': [
           '<(jinja_inputs_base_dir)/xml/searchable.xml',
           '<(jinja_inputs_base_dir)/xml/syncadapter.xml',
         ],
         'jinja_outputs_zip': '<(PRODUCT_DIR)/res.java/<(_target_name).zip',
         'jinja_variables': [
           'manifest_package=<(manifest_package)',
         ],
       },
       'all_dependent_settings': {
         'variables': {
           'additional_input_paths': ['<(jinja_outputs_zip)'],
           'dependencies_res_zip_paths': ['<(jinja_outputs_zip)'],
         },
       },
       'includes': [ '../../build/android/jinja_template.gypi' ],
     },
     {
-      # TODO(pvalenzuela): Implement this target with GN:
-      # http://crbug.com/475612
-      'target_name': 'chrome_sync_shell_template_resources',
+      # GN: //chrome/android:chrome_sync_shell_apk_template_resources
+      'target_name': 'chrome_sync_shell_apk_template_resources',
       'type': 'none',
       'variables': {
         'jinja_inputs_base_dir': 'java/res_template',
         'jinja_inputs': [
           '<(jinja_inputs_base_dir)/xml/searchable.xml',
           '<(jinja_inputs_base_dir)/xml/syncadapter.xml',
         ],
         'jinja_outputs_zip': '<(PRODUCT_DIR)/res.java/<(_target_name).zip',
         'jinja_variables': [
           'manifest_package=<(sync_shell_manifest_package)',
@@ skipping 53 matching lines @@
       'target_name': 'libchrome_public',
       'type': 'shared_library',
       'sources': [
         '<@(chrome_public_app_native_sources)',
       ],
       'dependencies': [
         'libchrome_public_base',
       ],
     },
     {
-      # TODO(pvalenzuela): Implement this target with GN:
-      # http://crbug.com/475612
+      # GN: //chrome/android:chrome_sync_shell
       'target_name': 'libchrome_sync_shell',
       'type': 'shared_library',
       'sources': [
-        '../browser/android/chrome_entry_point.cc',
-        '../browser/android/chrome_sync_shell_main_delegate_initializer.cc',
-        '../browser/android/chrome_sync_shell_main_delegate.h',
-        '../browser/android/chrome_sync_shell_main_delegate.cc',
+        '<@(chrome_sync_shell_app_native_sources)',
       ],
       'dependencies': [
         'libchrome_public_base',
         '../../sync/sync.gyp:sync',
         '../../sync/sync.gyp:test_support_sync_fake_server_android',
       ],
     },
     {
       # GN: //chrome/android:chrome_public_apk_manifest
       'target_name': 'chrome_public_manifest',
       'type': 'none',
       'variables': {
         'jinja_inputs': ['java/AndroidManifest.xml'],
         'jinja_output': '<(chrome_public_apk_manifest)',
         'jinja_variables': [
           'channel=<(android_channel)',
           'configuration_policy=<(configuration_policy)',
           'manifest_package=<(manifest_package)',
           'min_sdk_version=16',
           'target_sdk_version=23',
         ],
       },
       'includes': [ '../../build/android/jinja_template.gypi' ],
     },
     {
-      # TODO(pvalenzuela): Implement this target with GN:
-      # http://crbug.com/475612
-      'target_name': 'chrome_sync_shell_manifest',
+      # GN: //chrome/android:chrome_sync_shell_apk_manifest
+      'target_name': 'chrome_sync_shell_apk_manifest',
       'type': 'none',
       'variables': {
         'jinja_inputs': ['java/AndroidManifest.xml'],
         'jinja_output': '<(chrome_sync_shell_apk_manifest)',
         'jinja_variables': [
           'channel=<(android_channel)',
           'configuration_policy=<(configuration_policy)',
           'manifest_package=<(sync_shell_manifest_package)',
           'min_sdk_version=16',
           'target_sdk_version=22',
@@ skipping 17 matching lines @@
           # Only attempt loading the library from the APK for 64 bit devices
           # until the number of 32 bit devices which don't support this
           # approach falls to a minimal level -  http://crbug.com/390618.
           ['chrome_apk_use_chromium_linker==1 and profiling==0 and (target_arch == "arm64" or target_arch == "x86_64")', {
             'load_library_from_zip': '<(chrome_apk_load_library_from_zip)',
           }],
         ],
       },
       'dependencies': [
         'chrome_android_paks_copy',
-        'chrome_public_template_resources',
+        'chrome_public_apk_template_resources',
         'libchrome_public',
         '../chrome.gyp:chrome_java',
       ],
       'includes': [ 'chrome_apk.gypi' ],
     },
     {
       # GN: N/A
       # chrome_public_apk creates a .jar as a side effect. Any java targets
       # that need that .jar in their classpath should depend on this target,
       'target_name': 'chrome_public_apk_java',
       'type': 'none',
       'dependencies': [
         'chrome_public_apk',
       ],
       'includes': [ '../../build/apk_fake_jar.gypi' ],
     },
     {
-      # TODO(pvalenzuela): Implement this target with GN:
-      # http://crbug.com/475612
+      # GN: //chrome/android:chrome_sync_shell_apk
       'target_name': 'chrome_sync_shell_apk',
       'type': 'none',
       'variables': {
         'android_manifest_path': '<(chrome_sync_shell_apk_manifest)',
         'apk_name': 'ChromeSyncShell',
         'native_lib_target': 'libchrome_sync_shell',
         'java_in_dir': 'java',
         'enable_multidex': 1,
         'enable_multidex_configurations': ['Debug'],
         'conditions': [
           # Only attempt loading the library from the APK for 64 bit devices
           # until the number of 32 bit devices which don't support this
           # approach falls to a minimal level -  http://crbug.com/390618.
           ['chrome_apk_use_chromium_linker==1 and profiling==0 and (target_arch == "arm64" or target_arch == "x86_64")', {
             'load_library_from_zip': '<(chrome_apk_load_library_from_zip)',
           }],
         ],
       },
       'dependencies': [
         'chrome_android_paks_copy',
-        'chrome_sync_shell_template_resources',
+        'chrome_sync_shell_apk_template_resources',
         'libchrome_sync_shell',
         '../chrome.gyp:chrome_java',
         # This exists here because com.google.protobuf.nano is needed in tests,
         # but that code is stripped out via proguard. Adding this deps adds
         # usages and prevents removal of the proto code.
         '../../sync/sync.gyp:test_support_sync_proto_java',
       ],
       'includes': [ 'chrome_apk.gypi' ],
     },
     {
@@ skipping 42 matching lines @@
       'variables': {
         'jinja_inputs': ['javatests/AndroidManifest.xml'],
         'jinja_output': '<(chrome_public_test_apk_manifest)',
         'jinja_variables': [
           'manifest_package=<(manifest_package)',
         ],
       },
       'includes': [ '../../build/android/jinja_template.gypi' ],
     },
     {
-      # TODO(pvalenzuela): Implement this target with GN:
-      # http://crbug.com/475612
+      # GN: //chrome/android:chrome_sync_shell_test_apk_manifest
       'target_name': 'chrome_sync_shell_test_apk_manifest',
       'type': 'none',
       'variables': {
         'jinja_inputs': ['sync_shell/javatests/AndroidManifest.xml'],
         'jinja_output': '<(chrome_sync_shell_test_apk_manifest)',
         'jinja_variables': [
           'manifest_package=<(sync_shell_manifest_package)',
         ],
       },
       'includes': [ '../../build/android/jinja_template.gypi' ],
@@ skipping 17 matching lines @@
         'is_test_apk': 1,
         'test_type': 'instrumentation',
         'isolate_file': '../chrome_public_test_apk.isolate',
       },
       'includes': [
         '../../build/java_apk.gypi',
         '../../build/android/test_runner.gypi',
       ],
     },
     {
-      # TODO(pvalenzuela): Implement this target with GN:
-      # http://crbug.com/475612
+      # GN: //chrome/android:chrome_sync_shell_test_apk
       'target_name': 'chrome_sync_shell_test_apk',
       'type': 'none',
       'dependencies': [
         'chrome_sync_shell_apk_java',
         '../../base/base.gyp:base_java',
         '../../base/base.gyp:base_java_test_support',
         '../../chrome/chrome.gyp:chrome_java',
         '../../chrome/chrome.gyp:chrome_java_test_support',
         '../../sync/sync.gyp:sync_java',
         '../../sync/sync.gyp:sync_java_test_support',
@@ skipping 50 matching lines @@
       }
     ],
   ],
 }
 
 # Local Variables:
 # tab-width:2
 # indent-tabs-mode:nil
 # End:
 # vim: set expandtab tabstop=2 shiftwidth=2: