implement ES6 modules in JS AST.

implement ES6 modules in JS AST.
they aren't used by the Dart compiler yet, so this is just some scaffolding

R=ochafik@google.com, vsm@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/e9b7e6fc45ef0c95dd4d9274cce6f24f173417fa

[Jennifer Messerly, 2015-11-19 22:20:06]

jmesserly@google.com changed reviewers:
+ ochafik@google.com, vsm@google.com

[Jennifer Messerly, 2015-11-19 22:20:38]

this CL has been sitting on my hard drive forever, I removed the unfinished
parts. Intent is to add some of the initial scaffolding.

[ochafik, 2015-11-20 00:06:35]

LGTM, thanks John!

https://codereview.chromium.org/1458243002/diff/1/lib/src/js/nodes.dart
File lib/src/js/nodes.dart (right):

https://codereview.chromium.org/1458243002/diff/1/lib/src/js/nodes.dart#newco...
lib/src/js/nodes.dart:1611: String get importStarAs {
nit: should this be an Identifier?

https://codereview.chromium.org/1458243002/diff/1/lib/src/js/nodes.dart#newco...
lib/src/js/nodes.dart:1681: // TODO(jmesserly): should we wrap this in a node of
some sort?
(we'd need a special node for *, but otherwise Identifier seems a good
candidate)

[Jennifer Messerly, 2015-11-23 22:08:13]

https://codereview.chromium.org/1458243002/diff/1/lib/src/js/nodes.dart
File lib/src/js/nodes.dart (right):

https://codereview.chromium.org/1458243002/diff/1/lib/src/js/nodes.dart#newco...
lib/src/js/nodes.dart:1681: // TODO(jmesserly): should we wrap this in a node of
some sort?
On 2015/11/20 00:06:35, ochafik wrote:
> (we'd need a special node for *, but otherwise Identifier seems a good
> candidate)

yup, that's the main issue. The other one is that Identifiers make the tree
harder to build, which is a common reason to use the helpers like
js.statement('foo.bar.baz();') ... but then that needs parser support.

Under the assumption that these were just printed, and don't need source
locations, I left them as Strings to start. But I can see wanting to expand this
out to full Identifiers at some point in the future.

[vsm, 2015-11-30 16:28:08]

lgtm

[Jennifer Messerly, 2015-11-30 16:34:34]

Description was changed from

==========
implement ES6 modules in JS AST.
they aren't used by the Dart compiler yet, so this is just some scaffolding
==========

to

==========
implement ES6 modules in JS AST.
they aren't used by the Dart compiler yet, so this is just some scaffolding

R=ochafik@google.com, vsm@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/e9b7e6fc45ef0c95dd4d9274cce6...
==========

[Jennifer Messerly, 2015-11-30 16:34:35]

Committed patchset #1 (id:1) manually as
e9b7e6fc45ef0c95dd4d9274cce6f24f173417fa (presubmit successful).