Issue 1458233002: Revert of Add stroking support to distance field path renderer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1458233002: Revert of Add stroking support to distance field path renderer (Closed)

Created:
5 years, 1 month ago by jvanverth1

Modified:
5 years, 1 month ago

Reviewers:
robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of Add stroking support to distance field path renderer (patchset #7 id:120001 of https://codereview.chromium.org/1460873002/ ) Reason for revert: Asserting in nanobench and dm. Original issue's description: > Add stroking support to distance field path renderer > > Also slightly increases sizes of paths accepted for distance field > caching. > > Committed: https://skia.googlesource.com/skia/+/5ce76efd1c847308c7bcac17bd87d567c42cd786 TBR=robertphillips@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/b7361580f275bef90f28a62c58bac60ab64dc4cc

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -60 lines)			Patch
M	src/gpu/GrPathRenderer.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/gpu/batches/GrAADistanceFieldPathRenderer.h	View	1 chunk	+4 lines, -19 lines	0 comments	Download
M	src/gpu/batches/GrAADistanceFieldPathRenderer.cpp	View	10 chunks	+36 lines, -40 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jvanverth1

Created Revert of Add stroking support to distance field path renderer

5 years, 1 month ago (2015-11-19 21:18:39 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458233002/1

5 years, 1 month ago (2015-11-19 21:18:41 UTC) #2

commit-bot: I haz the power

5 years, 1 month ago (2015-11-19 21:18:49 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b7361580f275bef90f28a62c58bac60ab64dc4cc

Expand Messages | Collapse Messages