DevTools: Add dark theme hidden experiment

DevTools: Add dark theme hidden experiment

BUG=559524
Committed: https://crrev.com/a7d0f43f83b514a46ec3850aab3160412cdd8a53
Cr-Commit-Position: refs/heads/master@{#361015}

[paulirish, 2015-11-21 05:12:26]

paulirish@chromium.org changed reviewers:
+ pfeldman@chromium.org

[paulirish, 2015-11-21 05:12:27]

Screenshots: http://imgur.com/a/b6FMP


WDYT? TTFN

[paulirish, 2015-11-21 05:13:00]

Big thx to Sam on the invert() protip!

[pfeldman, 2015-11-21 06:00:01]

I'd rather trigger it upon 10 consecutive Shift keydowns.

[paulirish, 2015-11-21 06:01:26]

Sgtm. Will do.

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[paulirish, 2015-11-21 06:01:26]

Sgtm. Will do.

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[pfeldman, 2015-11-21 06:05:16]

(btw, invert thing came up several times but it never produced a quality enough
looks). now that we have experiments, we can afford that. I think it was caseq@
to implement it first :-P.

[pfeldman, 2015-11-21 06:07:05]

lgtm % nit

https://codereview.chromium.org/1458223005/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/inspectorStyle.css (right):

https://codereview.chromium.org/1458223005/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/inspectorStyle.css:559: background:
white;
move this into

body.dark-theme .root-view

[paulirish, 2015-11-21 07:20:14]

also, adjusted hue so colors now ~match light theme.
screenshots: http://imgur.com/a/nszZv

https://codereview.chromium.org/1458223005/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/inspectorStyle.css (right):

https://codereview.chromium.org/1458223005/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/inspectorStyle.css:559: background:
white;
On 2015/11/21 at 06:07:05, pfeldman wrote:
> move this into
> 
> body.dark-theme .root-view

done.

[paulirish, 2015-11-21 07:20:29]

The CQ bit was checked by paulirish@chromium.org

[paulirish, 2015-11-21 07:20:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1458223005/#ps20001
(title: "nit. now purple == purple, etc.")

[commit-bot: I haz the power, 2015-11-21 07:20:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1458223005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1458223005/20001

[commit-bot: I haz the power, 2015-11-21 08:51:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-21 08:52:16]

Patchset 2 (id:??) landed as
https://crrev.com/a7d0f43f83b514a46ec3850aab3160412cdd8a53
Cr-Commit-Position: refs/heads/master@{#361015}

[pfeldman, 2015-11-23 20:27:07]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1471693003/ by pfeldman@chromium.org.

The reason for reverting is: Since the theme does not work and can't be used,
this should really be behind 10 shifts..