content/browser/renderer_host/render_widget_host_view_mac.mm - Issue 1458203003: MacKeyboard: Don't generate keypress for non-printable char

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 1458203003: MacKeyboard: Don't generate keypress for non-printable char (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Filter more private use characters Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/input/web_input_event_builders_mac.mm ('K') | « content/browser/renderer_host/input/web_input_event_builders_mac.mm ('k') | content/browser/renderer_host/render_widget_host_view_mac_unittest.mm » ('j') | third_party/WebKit/Source/web/WebInputEventConversion.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_mac.mm

diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm

index 70f539dddb9144897e1d291f250d34794dc5c80e..d0e2fb9ced63ad62e49bc6541d9a5f8032892cae 100644

--- a/content/browser/renderer_host/render_widget_host_view_mac.mm

+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm

@@ -2300,7 +2300,7 @@ void RenderWidgetHostViewMac::OnDisplayMetricsChanged(

event.skip_in_browser = true;

widgetHost->ForwardKeyboardEvent(event);

} else if ((!textInserted || delayEventUntilAfterImeCompostion) &&

- [[theEvent characters] length] > 0 &&

+ event.text[0] != '\0' &&

dtapuska 2015/12/10 20:50:12 Can we use [[event text] length] > 0 ?

chongz 2015/12/11 06:38:46 Probably not because event.text is a WebUChar arra

(([theEvent modifierFlags] & kCtrlCmdKeyMask) ||

(hasEditCommands_ && editCommands_.empty()))) {

// We don't get insertText: calls if ctrl or cmd is down, or the key event