MacKeyboard: Don't generate keypress for non-printable char

third_party/WebKit/Source/web/WebInputEventConversion.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 305 matching lines @@
 
     if (type == RawKeyDown) {
         m_text = String();
         m_unmodifiedText = String();
     } else {
         m_keyIdentifier = String();
         m_windowsVirtualKeyCode = 0;
     }
 }
 
 // Please refer to bug http://b/issue?id=961192, which talks about Webkit

[erikchen, 2015/12/10 21:48:09]

This comment looks out of date. Can you update it, or just remove it?

[chongz, 2015/12/11 06:38:46]

Done.

 // keyboard event handling changes. It also mentions the list of keys
 // which don't have associated character events.
 bool PlatformKeyboardEventBuilder::isCharacterKey() const
 {
-    switch (windowsVirtualKeyCode()) {
-    case VKEY_BACK:
-    case VKEY_ESCAPE:
+    if (text().length() == 0)
         return false;
+
+    UChar32 c = text().characterStartingAt(0);
+    switch (c) {
+    case 0x08: // Backspace
+    case 0x1B: // Escape
+    case 0x7F: // Delete
+        return false;
+    default:
+        return true;
     }
-    return true;
 }
 
 inline PlatformEvent::Type toPlatformTouchEventType(const WebInputEvent::Type type)
 {
     switch (type) {
     case WebInputEvent::TouchStart:
         return PlatformEvent::TouchStart;
     case WebInputEvent::TouchMove:
         return PlatformEvent::TouchMove;
     case WebInputEvent::TouchEnd:
@@ skipping 378 matching lines @@
         break;
     case GestureSourceTouchscreen:
         sourceDevice = WebGestureDeviceTouchscreen;
         break;
     case GestureSourceUninitialized:
         ASSERT_NOT_REACHED();
     }
 }
 
 } // namespace blink