MacKeyboard: Don't generate keypress for non-printable char

content/browser/renderer_host/input/web_input_event_builders_mac.mm

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /*
  * Copyright (C) 2004, 2006, 2007 Apple Inc. All rights reserved.
  * Copyright (C) 2006-2009 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ skipping 613 matching lines @@
     unmodified_str = @"\x8";
   // Always use 9 for tab -- we don't want to use AppKit's different character
   // for shift-tab.
   if (result.windowsKeyCode == 9) {
     text_str = @"\x9";
     unmodified_str = @"\x9";
   }
 
   // End Apple code.
 
+  // Handle Apple's private use character
+  if ([text_str length] == 1) {

[dtapuska, 2015/12/10 20:50:12]

Can we do this in TextFromEvent and UnmodifiedTextFromEvent?

And put all the filtering code into a single function? 

[chongz, 2015/12/11 06:38:46]

Moved text_str filter into a single function, but should I create another
funtion for result.windowsKeyCode as well? 

+    unichar c = [text_str characterAtIndex:0];
+    if (c == NSDeleteFunctionKey) {
+      // Delete should be 0x7F
+      text_str = @"\x7F";
+    } else if (c >= 0xF700 && c <= 0xF747) {

[erikchen, 2015/12/10 21:48:09]

Where are you getting 0xF747 from?  

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...


seems to imply f7ff or f8ff might be a better choice. Either way, can you add a
comment with a link to an appropriate reference?

[dtapuska, 2015/12/10 21:53:01]

F7FF I'd prefer; would match this:

http://www.opensource.apple.com/source/WebCore/WebCore-7601.1.55/platform/mac...

[chongz, 2015/12/11 06:38:46]

Done.

+      // Other Apple private use characters should be "\0"
+      text_str = @"\0";
+    }
+  }
+  if ([unmodified_str length] == 1) {
+    unichar c = [unmodified_str characterAtIndex:0];
+    if (c == NSDeleteFunctionKey) {
+      // Delete should be 0x7F
+      unmodified_str = @"\x7F";
+    } else if (c >= 0xF700 && c <= 0xF747) {
+      // Other Apple private use characters should be "\0"
+      unmodified_str = @"\0";
+    }
+  }
+
   if ([text_str length] < blink::WebKeyboardEvent::textLengthCap &&
       [unmodified_str length] < blink::WebKeyboardEvent::textLengthCap) {
     [text_str getCharacters:&result.text[0]];
     [unmodified_str getCharacters:&result.unmodifiedText[0]];
   } else
     NOTIMPLEMENTED();
 
   [identifier_str getCString:&result.keyIdentifier[0]
                    maxLength:sizeof(result.keyIdentifier)
                     encoding:NSASCIIStringEncoding];
@@ skipping 274 matching lines @@
       break;
     default:
       NOTIMPLEMENTED();
       result.type = blink::WebInputEvent::Undefined;
   }
 
   return result;
 }
 
 }  // namespace content