Issue 14582024: Change media source switch to refer to the prefixed API.

Issue 14582024: Change media source switch to refer to the prefixed API. (Closed)

Created:
7 years, 7 months ago by acolwell GONE FROM CHROMIUM

Modified:
7 years, 7 months ago

Reviewers:
darin (slow to review), grt (UTC plus 2), scherkus (not reviewing)

CC:
chromium-reviews, grt+watch_chromium.org, amit, jam, joi+watch-content_chromium.org, robertshield, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Change media source switch to refer to the prefixed API. This is to make way for the flag that will control the unprefixed API that will be coming soon. BUG=239485 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200081

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address nit #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -17 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View	1 2 3	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome_frame/test/policy_settings_unittest.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/common/content_switches.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/common/content_switches.cc	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/renderer/render_thread_impl.cc	View	1 2 3	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

lgtm w/ pedantic grammar nit https://codereview.chromium.org/14582024/diff/1/content/public/common/content_switches.cc File content/public/common/content_switches.cc (right): https://codereview.chromium.org/14582024/diff/1/content/public/common/content_switches.cc#newcode341 content/public/common/content_switches.cc:341: // Disable prefixed Media ...

7 years, 7 months ago (2013-05-10 21:36:32 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/14582024/8001

7 years, 7 months ago (2013-05-13 15:24:08 UTC) #3

commit-bot: I haz the power

Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=2633

7 years, 7 months ago (2013-05-13 15:30:51 UTC) #4

acolwell GONE FROM CHROMIUM

jam@ : chrome and content OWNERs review grt@ : chrome_frame OWNERs review

7 years, 7 months ago (2013-05-13 15:34:09 UTC) #5

acolwell GONE FROM CHROMIUM

darin@ : OWNERS LGTM please for content/ & chrome/

7 years, 7 months ago (2013-05-14 15:56:58 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/14582024/17001

7 years, 7 months ago (2013-05-14 18:28:49 UTC) #9

commit-bot: I haz the power

7 years, 7 months ago (2013-05-14 21:28:01 UTC) #10

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

Expand Messages | Collapse Messages