Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: Source/WebKit/chromium/src/LinkHighlight.h

Issue 14582012: Clear highlight when the highlighted node gets removed from the document (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: add releaseResources() Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/WebKit/chromium/src/LinkHighlight.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 62
63 // WebAnimationDelegate implementation. 63 // WebAnimationDelegate implementation.
64 virtual void notifyAnimationStarted(double time) OVERRIDE; 64 virtual void notifyAnimationStarted(double time) OVERRIDE;
65 virtual void notifyAnimationFinished(double time) OVERRIDE; 65 virtual void notifyAnimationFinished(double time) OVERRIDE;
66 66
67 // LinkHighlightClient inplementation. 67 // LinkHighlightClient inplementation.
68 virtual void invalidate() OVERRIDE; 68 virtual void invalidate() OVERRIDE;
69 virtual WebLayer* layer() OVERRIDE; 69 virtual WebLayer* layer() OVERRIDE;
70 virtual void clearCurrentGraphicsLayer() OVERRIDE; 70 virtual void clearCurrentGraphicsLayer() OVERRIDE;
71 71
72 // For test only
73 WebCore::GraphicsLayerChromium* currentGraphicsLayer() const { return m_curr entGraphicsLayer; }
jamesr 2013/05/06 21:06:51 could you suffix the function name with 'ForTestin
74
72 private: 75 private:
73 LinkHighlight(WebCore::Node*, WebViewImpl*); 76 LinkHighlight(WebCore::Node*, WebViewImpl*);
74 77
75 void releaseResources(); 78 void releaseResources();
76 79
77 WebCore::RenderLayer* computeEnclosingCompositingLayer(); 80 WebCore::RenderLayer* computeEnclosingCompositingLayer();
78 void clearGraphicsLayerLinkHighlightPointer(); 81 void clearGraphicsLayerLinkHighlightPointer();
79 // This function computes the highlight path, and returns true if it has cha nged 82 // This function computes the highlight path, and returns true if it has cha nged
80 // size since the last call to this function. 83 // size since the last call to this function.
81 bool computeHighlightLayerPathAndPosition(WebCore::RenderLayer*); 84 bool computeHighlightLayerPathAndPosition(WebCore::RenderLayer*);
82 85
83 OwnPtr<WebContentLayer> m_contentLayer; 86 OwnPtr<WebContentLayer> m_contentLayer;
84 OwnPtr<WebLayer> m_clipLayer; 87 OwnPtr<WebLayer> m_clipLayer;
85 WebCore::Path m_path; 88 WebCore::Path m_path;
86 89
87 RefPtr<WebCore::Node> m_node; 90 RefPtr<WebCore::Node> m_node;
88 OwnPtr<WebAnimation> m_animation; 91 OwnPtr<WebAnimation> m_animation;
89 WebViewImpl* m_owningWebViewImpl; 92 WebViewImpl* m_owningWebViewImpl;
90 WebCore::GraphicsLayerChromium* m_currentGraphicsLayer; 93 WebCore::GraphicsLayerChromium* m_currentGraphicsLayer;
91 bool m_usingNonCompositedContentHost; 94 bool m_usingNonCompositedContentHost;
92 95
93 bool m_geometryNeedsUpdate; 96 bool m_geometryNeedsUpdate;
94 bool m_isAnimating; 97 bool m_isAnimating;
95 double m_startTime; 98 double m_startTime;
96 }; 99 };
97 100
98 } // namespace WebKit 101 } // namespace WebKit
99 102
100 #endif 103 #endif
OLDNEW
« no previous file with comments | « no previous file | Source/WebKit/chromium/src/LinkHighlight.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698