Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Issue 1458193003: Move glyph choosing to the find and place glyph code. (Closed)

Created:
5 years, 1 month ago by herb_g
Modified:
5 years, 1 month ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move glyph choosing to the find and place glyph code. This duplicates the functionality of the (private) SkPaint::getDrawCacheProc method into SkFindAndPlaceGlyph::LookupGlyph. Eventually LookupGlyph should replace getDrawCacheProc, at which point it should be removed. The remaining users are gpu and pdf. Committed: https://skia.googlesource.com/skia/+/4c11b3f8a2d9919a21110dbdd29e67e5cbaa41fb

Patch Set 1 #

Patch Set 2 : Comments and fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -58 lines) Patch
M src/core/SkDraw.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M src/core/SkFindAndPlaceGlyph.h View 1 19 chunks +161 lines, -48 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
herb_g
Comments and fixes.
5 years, 1 month ago (2015-11-20 17:48:10 UTC) #1
herb_g
This CL will make it so I don't have to make XPS device a friend ...
5 years, 1 month ago (2015-11-20 18:05:58 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458193003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458193003/20001
5 years, 1 month ago (2015-11-20 18:31:33 UTC) #8
bungeman-skia
lgtm
5 years, 1 month ago (2015-11-20 19:04:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458193003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458193003/20001
5 years, 1 month ago (2015-11-20 19:04:32 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 21:53:15 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/4c11b3f8a2d9919a21110dbdd29e67e5cbaa41fb

Powered by Google App Engine
This is Rietveld 408576698