Flip the CrOS GN release bots to use Ozone.

Flip the CrOS GN release bots to use Ozone.

Ozone should probably be the default config for ChromiumOS-based
builds these days, but we still need to support X11-based builds
as well.

This CL flips the GN ChromiumOS release bots (waterfall and
tryserver) to use Ozone, but leaves the debug bots using X11.
Note that only the release bot is in the CQ currently.

Also, make sure that both configs are building 'gn_all'.

R=petermayo@chromium.org
TBR=isherman@chromium.org, sky@chromium.org
BUG=433082
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_gn_chromeos_dbg

Committed: https://crrev.com/244f973d640e156aaa7dccdbdec09d612b58fdf9
Cr-Commit-Position: refs/heads/master@{#360754}

[Dirk Pranke, 2015-11-19 19:21:16]

Description was changed from

==========
Flip the CrOS GN release bots to use Ozone.

Ozone should probably be the default config for ChromiumOS-based
builds these days, but we still need to support X11-based builds
as well.

This CL flips the GN ChromiumOS release bots (waterfall and
tryserver) to use Ozone, but leaves the debug bots using X11.
Note that only the release bot is in the CQ currently.

Also, make sure that both configs are building 'gn_all'.

R=wez@chromium.org, petermayo@chromium.org, dnj@chromium.org
BUG=433082
==========

to

==========
Flip the CrOS GN release bots to use Ozone.

Ozone should probably be the default config for ChromiumOS-based
builds these days, but we still need to support X11-based builds
as well.

This CL flips the GN ChromiumOS release bots (waterfall and
tryserver) to use Ozone, but leaves the debug bots using X11.
Note that only the release bot is in the CQ currently.

Also, make sure that both configs are building 'gn_all'.

R=wez@chromium.org, petermayo@chromium.org, dnj@chromium.org
BUG=433082
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_gn_chromeos_dbg
==========

[Dirk Pranke, 2015-11-19 19:24:14]

The CQ bit was checked by dpranke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-19 19:25:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1458193002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1458193002/1

[Peter Mayo, 2015-11-19 22:13:02]

LGTM

But I'm not all that looped into the ozone versus non-ozone density of ChromeOS
today.

[Dirk Pranke, 2015-11-19 23:42:26]

Description was changed from

==========
Flip the CrOS GN release bots to use Ozone.

Ozone should probably be the default config for ChromiumOS-based
builds these days, but we still need to support X11-based builds
as well.

This CL flips the GN ChromiumOS release bots (waterfall and
tryserver) to use Ozone, but leaves the debug bots using X11.
Note that only the release bot is in the CQ currently.

Also, make sure that both configs are building 'gn_all'.

R=wez@chromium.org, petermayo@chromium.org, dnj@chromium.org
BUG=433082
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_gn_chromeos_dbg
==========

to

==========
Flip the CrOS GN release bots to use Ozone.

Ozone should probably be the default config for ChromiumOS-based
builds these days, but we still need to support X11-based builds
as well.

This CL flips the GN ChromiumOS release bots (waterfall and
tryserver) to use Ozone, but leaves the debug bots using X11.
Note that only the release bot is in the CQ currently.

Also, make sure that both configs are building 'gn_all'.

R=petermayo@chromium.org
TBR=isherman@chromium.org, sky@chromium.org
BUG=433082
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_gn_chromeos_dbg
==========

[Dirk Pranke, 2015-11-19 23:42:36]

The CQ bit was checked by dpranke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-19 23:46:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1458193002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1458193002/40001

[commit-bot: I haz the power, 2015-11-20 00:44:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-20 00:44:17]

Dry run: Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[Dirk Pranke, 2015-11-20 02:33:24]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2015-11-20 02:33:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
petermayo@chromium.org
Link to the patchset: https://codereview.chromium.org/1458193002/#ps60001
(title: "fix target nesting")

[commit-bot: I haz the power, 2015-11-20 02:38:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1458193002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1458193002/60001

[Peter Mayo, 2015-11-20 02:42:27]

On 2015/11/20 02:38:16, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1458193002/60001
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1458193002/60001

Still LGTM.

There are a lot of ordering/sorting changes that make reading the more
substantial changes slower.

[Dirk Pranke, 2015-11-20 02:49:04]

On 2015/11/20 02:42:27, Peter Mayo wrote:
> There are a lot of ordering/sorting changes that make reading the more
> substantial changes slower.

yes, unfortunately; in merging to HEAD we picked up the latest GN binary which
requires the deps to be sorted.

worse, it looks like the sorting is a bit wrong, in that it sorts "foo/bar"
after "//foo/bar", which, will correct according
to normal unix sorting order, is probably not what we want.

[commit-bot: I haz the power, 2015-11-20 05:38:17]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-11-20 05:39:01]

Patchset 4 (id:??) landed as
https://crrev.com/244f973d640e156aaa7dccdbdec09d612b58fdf9
Cr-Commit-Position: refs/heads/master@{#360754}