xfa/src/fwl/src/basewidget/include/fwl_comboboximp.h - Issue 1458173002: Fix CFWL_WidgetImpDelegate hierarchy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fwl/src/basewidget/include/fwl_comboboximp.h

Issue 1458173002: Fix CFWL_WidgetImpDelegate hierarchy. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« xfa/src/fwl/src/basewidget/fwl_barcodeimp.cpp ('K') | « xfa/src/fwl/src/basewidget/include/fwl_checkboximp.h ('k') | xfa/src/fwl/src/basewidget/include/fwl_datetimepickerimp.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: xfa/src/fwl/src/basewidget/include/fwl_comboboximp.h

diff --git a/xfa/src/fwl/src/basewidget/include/fwl_comboboximp.h b/xfa/src/fwl/src/basewidget/include/fwl_comboboximp.h

index e0c19118b5217750500fa027544c4d82c21e3c70..f824fa1c2f35dfc07fe14310914be7998cdaa2b9 100644

--- a/xfa/src/fwl/src/basewidget/include/fwl_comboboximp.h

+++ b/xfa/src/fwl/src/basewidget/include/fwl_comboboximp.h

@@ -41,7 +41,7 @@ class CFWL_ComboEditImp : public CFWL_EditImp {

class CFWL_ComboEditImpDelegate : public CFWL_EditImpDelegate {

public:

CFWL_ComboEditImpDelegate(CFWL_ComboEditImp* pOwner);

- virtual int32_t OnProcessMessage(CFWL_Message* pMessage);

+ int32_t OnProcessMessage(CFWL_Message* pMessage) override;

protected:

CFWL_ComboEditImp* m_pOwner;

@@ -66,7 +66,7 @@ class CFWL_ComboListImp : public CFWL_ListBoxImp {

class CFWL_ComboListImpDelegate : public CFWL_ListBoxImpDelegate {

public:

CFWL_ComboListImpDelegate(CFWL_ComboListImp* pOwner);

- virtual int32_t OnProcessMessage(CFWL_Message* pMessage);

+ int32_t OnProcessMessage(CFWL_Message* pMessage) override;

protected:

void OnDropListFocusChanged(CFWL_Message* pMsg, FX_BOOL bSet = TRUE);

@@ -190,10 +190,10 @@ class CFWL_ComboBoxImp : public CFWL_WidgetImp {

class CFWL_ComboBoxImpDelegate : public CFWL_WidgetImpDelegate {

public:

CFWL_ComboBoxImpDelegate(CFWL_ComboBoxImp* pOwner);

- virtual int32_t OnProcessMessage(CFWL_Message* pMessage);

- virtual FWL_ERR OnProcessEvent(CFWL_Event* pEvent);

- virtual FWL_ERR OnDrawWidget(CFX_Graphics* pGraphics,

- const CFX_Matrix* pMatrix = NULL);

+ int32_t OnProcessMessage(CFWL_Message* pMessage) override;

+ FWL_ERR OnProcessEvent(CFWL_Event* pEvent) override;

+ FWL_ERR OnDrawWidget(CFX_Graphics* pGraphics,

+ const CFX_Matrix* pMatrix = NULL) override;

protected:

void OnFocusChanged(CFWL_Message* pMsg, FX_BOOL bSet = TRUE);

@@ -218,9 +218,9 @@ class CFWL_ComboBoxImpDelegate : public CFWL_WidgetImpDelegate {

class CFWL_ComboProxyImpDelegate : public CFWL_WidgetImpDelegate {

public:

CFWL_ComboProxyImpDelegate(IFWL_Form* pForm, CFWL_ComboBoxImp* pComboBox);

- virtual int32_t OnProcessMessage(CFWL_Message* pMessage);

- virtual FWL_ERR OnDrawWidget(CFX_Graphics* pGraphics,

- const CFX_Matrix* pMatrix = NULL);

+ int32_t OnProcessMessage(CFWL_Message* pMessage) override;

+ FWL_ERR OnDrawWidget(CFX_Graphics* pGraphics,

+ const CFX_Matrix* pMatrix = NULL) override;

void Reset() { m_bLButtonUpSelf = FALSE; }

protected: