enable conservative raster clipping

enable conservative raster clipping

There may be other (better?) ways to enable this. For example, if we queried the device *before* we init our root DeviceCM, we wouldn't need this flag in InitFlags, since the device already has a virtual to opt-in ...

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/42b73eb00367c8315974b1c374308d20efa78897

[reed1, 2015-11-19 22:18:57]

Description was changed from

==========
enable conservative raster clipping

BUG=skia:
==========

to

==========
enable conservative raster clipping

There may be other (better?) ways to enable this. For example, if we queried the
device *before* we init our root DeviceCM, we wouldn't need this flag in
InitFlags, since the device already has a virtual to opt-in ...

BUG=skia:
==========

[reed1, 2015-11-19 22:18:58]

reed@google.com changed reviewers:
+ bsalomon@google.com, djsollen@google.com, robertphillips@google.com

[reed1, 2015-11-20 19:20:49]

ptal

[reed1, 2015-11-20 19:20:52]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2015-11-20 19:21:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1458153003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1458153003/20001

[commit-bot: I haz the power, 2015-11-20 19:21:04]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-11-21 01:21 UTC

[bsalomon, 2015-11-20 19:39:25]

lgtm, but perhaps we could consider adding more SkCanvas constructors.

[robertphillips, 2015-11-20 19:45:47]

lgtm + a question

https://codereview.chromium.org/1458153003/diff/20001/src/core/SkCanvas.cpp
File src/core/SkCanvas.cpp (right):

https://codereview.chromium.org/1458153003/diff/20001/src/core/SkCanvas.cpp#n...
src/core/SkCanvas.cpp:632: }
Why don't we just do this inside the above else:

*const_cast<bool*>(&fConservativeRasterClip) = true;

?

[robertphillips, 2015-11-20 19:47:14]

The CQ bit was unchecked by robertphillips@google.com

[reed1, 2015-11-20 20:29:11]

On 2015/11/20 19:39:25, bsalomon wrote:
> lgtm, but perhaps we could consider adding more SkCanvas constructors.

oh yea, more more more.

[reed1, 2015-11-20 20:46:34]

https://codereview.chromium.org/1458153003/diff/20001/src/core/SkCanvas.cpp
File src/core/SkCanvas.cpp (right):

https://codereview.chromium.org/1458153003/diff/20001/src/core/SkCanvas.cpp#n...
src/core/SkCanvas.cpp:632: }
On 2015/11/20 19:45:47, robertphillips wrote:
> Why don't we just do this inside the above else:
> 
> *const_cast<bool*>(&fConservativeRasterClip) = true;
> 
> ?

doesn't seem smaller or clearer (to me) since it presumes that no one else will
ever look at flags (since it will now be "out of date" with the true sense...
(assuming your proposal is to replace the bit-or with assign=true)

[reed1, 2015-11-20 21:33:30]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2015-11-20 21:33:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1458153003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1458153003/20001

[commit-bot: I haz the power, 2015-11-20 21:42:45]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/42b73eb00367c8315974b1c374308d20efa78897